commit 981e28db0809453d80ab535f1fe062893ec8a555
author darin <darin@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Mon Jul 10 15:53:47 2006 +0000
committer darin <darin@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Mon Jul 10 15:53:47 2006 +0000
tree 198a5b1d3e4a5ec041a43507aad00f5651023ba9
parent 848bd97f01e3cffbbccb94f6663f146974ea717b

        Reviewed by Anders.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9833
          REGRESSION: Reproducible crash: RenderMenuList.cpp:58: failed assertion `!m_first'

        * manual-tests/empty-title-popup.html: Added.

        * rendering/RenderMenuList.h: Add createInnerBlock.
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::createInnerBlock): Factored out of addChild.
        (WebCore::RenderMenuList::addChild): Call createInnerBlock.
        (WebCore::RenderMenuList::setText): Changed parameter type.
        (WebCore::RenderMenuList::showPopup): Call createInnerBlock before calling
        the parent class's addChild.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/manual-tests/empty-title-popup.html

diff --git a/WebCore/manual-tests/empty-title-popup.html b/WebCore/manual-tests/empty-title-popup.html
new file mode 100644
index 0000000..d5be5b9
--- /dev/null
+++ b/WebCore/manual-tests/empty-title-popup.html
@@ -0,0 +1,3 @@
+<p>This demonstrates <a href="http://bugzilla.opendarwin.org/show_bug.cgi?id=9833">bug 9833</a>.</p>
+<p>Select the second item on the pop up.
+<select><option></option><option>Pick me!</option></select></p>