commit | 965e78d0b35185e2810d6627d5064f8c29fd18a9 | [log] [tgz] |
---|---|---|
author | alexm@gnome.org <alexm@gnome.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Wed Jan 26 21:59:56 2022 +0000 |
committer | alexm@gnome.org <alexm@gnome.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Wed Jan 26 21:59:56 2022 +0000 |
tree | 7ab163340b0fcbd35bdc3fe4ac284151a39c08b7 | |
parent | 7e7e2d918d7e1a0018ebe83443f8a7bdffbb2f59 [diff] |
[GTK3] Pinch zooming from a link activates it https://bugs.webkit.org/show_bug.cgi?id=235639 Reviewed by Carlos Garcia Campos. Turns out gestures behave differently between GTK3 and 4. On GTK4 it works fine, but on GTK3 starting a pinch zoom triggers the multipress gesture when one finger is down, and completes it when the second finger is down. This results in a bogus click, with no way to prevent it as it happens before any of the zoom callbacks are called. Since we can't know if there will be a zoom afterwards or not, we can't do anything about it. However, what we can do is reorder these gestures. In GTK3 the order the gestures are processed in depends on which order they were created in. At that point, there's a problem with the fact the gestures are grouped. Grouping means that these 2 gestures are triggered at the same time. While somehow the press gesture is still triggered without grouping with the original order, they become properly decoupled in reverse order and ungrouped. At that point, we can safely cancel the press gesture when the zoom gesture starts, and fix the issue. This seems to still work fine for GTK4. * UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseZoomBegin): (webkitWebViewBaseConstructed): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@288644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit is a cross-platform web browser engine. On iOS and macOS, it powers Safari, Mail, iBooks, and many other applications.
Visit WebKit Feature Status page to see which Web API has been implemented, in development, or under consideration.
On macOS, download Safari Technology Preview to test the latest version of WebKit. On Linux, download Epiphany Technology Preview. On Windows, you'll have to build it yourself.
Once your bug is filed, you will receive email when it is updated at each stage in the bug life cycle. After the bug is considered fixed, you may be asked to download the latest nightly and confirm that the fix works for you.
On Windows, follow the instructions on our website.
Run the following command to clone WebKit's Git SVN repository:
git clone git@github.com:WebKit/WebKit.git WebKit
or
git clone https://github.com/WebKit/WebKit.git WebKit
If you want to be able to track Subversion revision from your git checkout, you can run the following command to do so:
Tools/Scripts/git-webkit setup-git-svn
For information about this, and other aspects of using Git with WebKit, read the wiki page.
If you don‘t want to use Git, run the following command to check out WebKit’s Subversion repository:
svn checkout https://svn.webkit.org/repository/webkit/trunk WebKit
Install Xcode and its command line tools if you haven't done so already:
xcode-select --install
Run the following command to build a debug build with debugging symbols and assertions:
Tools/Scripts/build-webkit --debug
For performance testing, and other purposes, use --release
instead.
You can open WebKit.xcworkspace
to build and debug WebKit within Xcode.
If you don't use a custom build location in Xcode preferences, you have to update the workspace settings to use WebKitBuild
directory. In menu bar, choose File > Workspace Settings, then click the Advanced button, select “Custom”, “Relative to Workspace”, and enter WebKitBuild
for both Products and Intermediates.
iOS, tvOS and watchOS are all considered embedded builds. The first time after you install a new Xcode, you will need to run:
sudo Tools/Scripts/configure-xcode-for-embedded-development
Without this step, you will see the error message: “target specifies product type ‘com.apple.product-type.tool’, but there’s no such product type for the ‘iphonesimulator’ platform.
” when building target JSCLLIntOffsetsExtractor
of project JavaScriptCore
.
Run the following command to build a debug build with debugging symbols and assertions for embedded simulators:
Tools/Scripts/build-webkit --debug --<platform>-simulator
or embedded devices:
Tools/Scripts/build-webkit --debug --<platform>-device
where platform
is ios
, tvos
or watchos
.
For production builds:
cmake -DPORT=GTK -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/gtk/install-dependencies Tools/Scripts/update-webkitgtk-libs Tools/Scripts/build-webkit --gtk --debug
For more information on building WebKitGTK+, see the wiki page.
For production builds:
cmake -DPORT=WPE -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/wpe/install-dependencies Tools/Scripts/update-webkitwpe-libs Tools/Scripts/build-webkit --wpe --debug
For building WebKit on Windows, see the wiki page.
Run the following command to launch Safari with your local build of WebKit:
Tools/Scripts/run-safari --debug
The run-safari
script sets the DYLD_FRAMEWORK_PATH
environment variable to point to your build products, and then launches /Applications/Safari.app
. DYLD_FRAMEWORK_PATH
tells the system loader to prefer your build products over the frameworks installed in /System/Library/Frameworks
.
To run other applications with your local build of WebKit, run the following command:
Tools/Scripts/run-webkit-app <application-path>
Run the following command to launch iOS simulator with your local build of WebKit:
run-safari --debug --ios-simulator
In both cases, if you have built release builds instead, use --release
instead of --debug
.
If you have a development build, you can use the run-minibrowser script, e.g.:
run-minibrowser --debug --wpe
Pass one of --gtk
, --jsc-only
, or --wpe
to indicate the port to use.
Congratulations! You’re up and running. Now you can begin coding in WebKit and contribute your fixes and new features to the project. For details on submitting your code to the project, read Contributing Code.