commit | 93614ab67ef69a9fa7c4815ff98a815511863e9c | [log] [tgz] |
---|---|---|
author | wenson_hsieh@apple.com <wenson_hsieh@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Thu Apr 02 19:06:46 2020 +0000 |
committer | wenson_hsieh@apple.com <wenson_hsieh@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Thu Apr 02 19:06:46 2020 +0000 |
tree | dc75461f39e56e12a29d517c669bf9c7b0d21be1 | |
parent | 1b30f748f57009fa3dcb9e3037cee242dbc7934e [diff] |
Avoid null deref after inserting a text field with a list attribute https://bugs.webkit.org/show_bug.cgi?id=209909 <rdar://problem/60742229> Reviewed by Ryosuke Niwa. Source/WebCore: On macOS, when painting a text field with an associated datalist (i.e. `HTMLInputElement::list()` is non-null), we assume that the datalist suggestions dropdown button has a renderer (in other words, it does not have a style of `display: none`). Existing logic in `TextFieldInputType` is responsible for upholding this invariant -- when the list attribute changes on an input field (e.g. when we parse the list attribute, or when it is set by JavaScript), we update the inline display style of `m_dataListDropdownIndicator`, such that it is set to `display: none` only if there is either no list attribute, or the list attribute is empty, or the list does not refer to a connected datalist element. However, there is one scenario in which this invariant is violated. Consider the following: 1. An input field is created, and its list attribute is set to "foo". Importantly, it is not connected yet. 2. A datalist element with id "foo" is then created and then added to the document. 3. The input field created in (1) is then added to the document. In this scenario, `listAttributeTargetChanged()` is invoked after (1), but since it is not connected, it has no datalist yet, and so `m_dataListDropdownIndicator` will remain non-rendered. When it is later added to the DOM, nothing attempts to `m_dataListDropdownIndicator` even though its list attribute now refers to a datalist, so it remains hidden. When we later go to paint the input's datalist dropdown button in `RenderThemeMac::paintListButtonForInput`, we assume that the dropdown button must be rendered because the input has a datalist and subsequently crash since `buttonElement->renderer()` remains null. To fix this, we add logic to update the datalist dropdown button's inline display style when it is connected to the document with an existing, non-empty list attribute. Test: fast/forms/datalist/append-input-with-list-attribute.html * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseAttribute): (WebCore::HTMLInputElement::didFinishInsertingNode): Notify the InputType subclass that the datalist element may have changed after an input element is connected to the document with a non-empty list attribute. (WebCore::HTMLInputElement::dataListMayHaveChanged): (WebCore::ListAttributeTargetObserver::idTargetChanged): (WebCore::HTMLInputElement::listAttributeTargetChanged): Deleted. Rename listAttributeTargetChanged to dataListMayHaveChanged, since it is no longer called only when the list attribute changes value, but rather when the input's datalist element may have changed. * html/HTMLInputElement.h: * html/InputType.cpp: (WebCore::InputType::dataListMayHaveChanged): (WebCore::InputType::listAttributeTargetChanged): Deleted. * html/InputType.h: * html/RangeInputType.cpp: (WebCore::RangeInputType::dataListMayHaveChanged): (WebCore::RangeInputType::listAttributeTargetChanged): Deleted. * html/RangeInputType.h: * html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::dataListMayHaveChanged): (WebCore::TextFieldInputType::listAttributeTargetChanged): Deleted. * html/TextFieldInputType.h: LayoutTests: Add a layout test to exercise the crashing scenario, and verify that the end result of programmatically inserting the text field is identical to simply putting an input field with a datalist in the markup. * fast/forms/datalist/append-input-with-list-attribute-expected.html: Added. * fast/forms/datalist/append-input-with-list-attribute.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@259402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit is a cross-platform web browser engine. On iOS and macOS, it powers Safari, Mail, iBooks, and many other applications.
Visit WebKit Feature Status page to see which Web API has been implemented, in development, or under consideration.
On macOS, download Safari Technology Preview to test the latest version of WebKit. On Linux, download Epiphany Technology Preview. On Windows, you'll have to build it yourself.
Once your bug is filed, you will receive email when it is updated at each stage in the bug life cycle. After the bug is considered fixed, you may be asked to download the latest nightly and confirm that the fix works for you.
On Windows, follow the instructions on our website.
Run the following command to clone WebKit's Git SVN repository:
git clone git://git.webkit.org/WebKit.git WebKit
or
git clone https://git.webkit.org/git/WebKit.git WebKit
If you want to be able to commit changes to the repository, or just want to check out branches that aren’t contained in WebKit.git, you will need track WebKit's Subversion repository. You can run the following command to configure this and other options of the new Git clone for WebKit development.
Tools/Scripts/webkit-patch setup-git-clone
For information about this, and other aspects of using Git with WebKit, read the wiki page.
If you don‘t want to use Git, run the following command to check out WebKit’s Subversion repository:
svn checkout https://svn.webkit.org/repository/webkit/trunk WebKit
Install Xcode and its command line tools if you haven't done so already:
xcode-select --install
Run the following command to build a debug build with debugging symbols and assertions:
Tools/Scripts/build-webkit --debug
For performance testing, and other purposes, use --release
instead.
You can open WebKit.xcworkspace
to build and debug WebKit within Xcode.
If you don't use a custom build location in Xcode preferences, you have to update the workspace settings to use WebKitBuild
directory. In menu bar, choose File > Workspace Settings, then click the Advanced button, select “Custom”, “Relative to Workspace”, and enter WebKitBuild
for both Products and Intermediates.
The first time after you install a new Xcode, you will need to run the following command to enable Xcode to build command line tools for iOS Simulator:
sudo Tools/Scripts/configure-xcode-for-ios-development
Without this step, you will see the error message: “target specifies product type ‘com.apple.product-type.tool’, but there’s no such product type for the ‘iphonesimulator’ platform.
” when building target JSCLLIntOffsetsExtractor
of project JavaScriptCore
.
Run the following command to build a debug build with debugging symbols and assertions for iOS:
Tools/Scripts/build-webkit --debug --ios-simulator
For production builds:
cmake -DPORT=GTK -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/gtk/install-dependencies Tools/Scripts/update-webkitgtk-libs Tools/Scripts/build-webkit --gtk --debug
For more information on building WebKitGTK+, see the wiki page.
For production builds:
cmake -DPORT=WPE -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/wpe/install-dependencies Tools/Scripts/update-webkitwpe-libs Tools/Scripts/build-webkit --wpe --debug
For building WebKit on Windows, see the wiki page.
Run the following command to launch Safari with your local build of WebKit:
Tools/Scripts/run-safari --debug
The run-safari
script sets the DYLD_FRAMEWORK_PATH
environment variable to point to your build products, and then launches /Applications/Safari.app
. DYLD_FRAMEWORK_PATH
tells the system loader to prefer your build products over the frameworks installed in /System/Library/Frameworks
.
To run other applications with your local build of WebKit, run the following command:
Tools/Scripts/run-webkit-app <application-path>
Run the following command to launch iOS simulator with your local build of WebKit:
run-safari --debug --ios-simulator
In both cases, if you have built release builds instead, use --release
instead of --debug
.
If you have a development build, you can use the run-minibrowser script, e.g.:
run-minibrowser --debug --wpe
Pass one of --gtk
, --jsc-only
, or --wpe
to indicate the port to use.
Congratulations! You’re up and running. Now you can begin coding in WebKit and contribute your fixes and new features to the project. For details on submitting your code to the project, read Contributing Code.