commit | 91d8370969ef72232b8ed35b1c6e147142059249 | [log] [tgz] |
---|---|---|
author | rniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Wed Aug 23 21:40:41 2017 +0000 |
committer | rniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Wed Aug 23 21:40:41 2017 +0000 |
tree | 573ea5c3b3429ffa0df941dfb91d17211b1ecd4a | |
parent | e2acc410d90589072928e72d912714428fda7522 [diff] |
Speedometer 2.0: Async time is not always capturing layout time https://bugs.webkit.org/show_bug.cgi?id=175871 Reviewed by Simon Fraser. Speedometer harness was designed to capture the time browser engine spends relayouting and repainting the content after DOM mutations this in its async time measurement, which is the time between each test case's code had finished running and when a newly scheduled 0s timer is fired immediately afterwards. It turns out that modern web browsers defer this reflow and repaint work until the next animation frame is requested. This results in Speedometer harness measuring reflow and repaint cost only sometimes depending on when each test case had finished running relative to the next frame request. While such a behavior makes sense and might be desirable for a modern browser engine, we would like to capture it in the async time for the purpose of Speedometer. Unfortunately, there isn't an interoperable API for browsers to report the total layout and repaint time, and relying on 16ms-granularity requestAnimationFrame is too coarse for Speedometer. This patch works around these limitations by manually forcing the layout in async time measurement by calling getBoundingClientRect() in iframe's document. Since the height of the document depends on the number of todo items, this should cause browser engines to do most if not all of the work needed to reflow the document at least for now. Note that even new async time doesn't always capture painting time but there isn't a good cross-browser mechanism to measure paint time in the granurality we need for Speedometer at the moment anyway. (Should such a mechanism exist, that could be a huge timing attack surface so it's probably best that we don't have one.) * Speedometer/resources/benchmark-runner.js: (BenchmarkRunner.prototype._runTest): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@221106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit is a cross-platform web browser engine. On iOS and macOS, it powers Safari, Mail, iBooks, and many other applications.
Visit WebKit Feature Status page to see which Web API has been implemented, in development, or under consideration.
Downloading Safari Technology Preview to test the latest version of WebKit.
Once your bug is filed, you will receive email when it is updated at each stage in the bug life cycle. After the bug is considered fixed, you may be asked to download the latest nightly and confirm that the fix works for you.
On Windows, follow the instructions on our website.
Run the following command to clone WebKit's Git SVN repository:
git clone git://git.webkit.org/WebKit.git WebKit
If you want to be able to commit changes to the repository, or just want to check out branches that aren’t contained in WebKit.git, you will need track WebKit's Subversion repository. You can run the following command to configure this and other options of the new Git clone for WebKit development.
Tools/Scripts/webkit-patch setup-git-clone
For information about this, and other aspects of using Git with WebKit, read the wiki page.
Run the following command to check out WebKit's subversion repository:
svn checkout https://svn.webkit.org/repository/webkit/trunk WebKit
Install Xcode and its command line tools if you haven't done so already:
xcode-select --install
Run the following command to build a debug build with debugging symbols and assertions:
Tools/Scripts/build-webkit --debug
For performance testing, and other purposes, use --release
instead.
You can open WebKit.xcworkspace
to build and debug WebKit within WebKit.
If you don't use a custom build location in Xcode preferences, you have to update the workspace settings to use WebKitBuild
directory. In menu bar, choose File > Workspace Settings, then click the Advanced button, select “Custom”, “Relative to Workspace”, and enter WebKitBuild
for both Products and Intermediates.
The first time after you install a new Xcode, you will need to run the following command to enable Xcode to build command line tools for iOS Simulator:
sudo Tools/Scripts/configure-xcode-for-ios-development
Without this step, you will see the error message: “target specifies product type ‘com.apple.product-type.tool’, but there’s no such product type for the ‘iphonesimulator’ platform.
” when building target JSCLLIntOffsetsExtractor
of project JavaScriptCore
.
Run the following command to build a debug build with debugging symbols and assertions for iOS:
Tools/Scripts/build-webkit --debug --ios-simulator.
Install the dependencies by running the following command:
Tools/gtk/install-dependencies
Then run the following command to build additional dependencies:
Tools/Scripts/update-webkitgtk-libs
Run the following command to build WebKit with debugging symbols for GTK+ port:
Tools/Scripts/build-webkit --debug --gtk
Note that the procedure for building a release tarball is different. For more information, see the wiki page.
For building WebKit on Windows, see the wiki page.
Run the following command to launch Safari with your local build of WebKit:
Tools/Scripts/run-safari --debug
The run-safari
script sets the DYLD_FRAMEWORK_PATH
environment variable to point to your build products, and then launches /Applications/Safari.app
. DYLD_FRAMEWORK_PATH
tells the system loader to prefer your build products over the frameworks installed in /System/Library/Frameworks
.
To run other applications with your local build of WebKit, run the following command:
Tools/Scripts/run-webkit-app <application-path>
Run the following command to launch iOS simulator with your local build of WebKit:
run-safari --debug --ios-simulator
In both cases, if you have built release builds instead, use --release
instead of --debug
.
Congratulations! You’re up and running. Now you can begin coding in WebKit and contribute your fixes and new features to the project. For details on submitting your code to the project, read Contributing Code.