| commit | 8a8c2cfc49dce2f0e2f8651d39906dd8c646859b | [log] [tgz] |
|---|---|---|
| author | simon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Tue Jan 29 21:29:27 2019 +0000 |
| committer | simon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Tue Jan 29 21:29:27 2019 +0000 |
| tree | 9185d4f9b5537da1bcd7182172b069ec8d3996e8 | |
| parent | fe9066b5bbb0b418cee11a0e6c17f1808da891b2 [diff] |
REGRESSION(r240553): [iOS] Crash in ScrollingTree::updateTreeFromStateNode when attempting to log in to icloud.com https://bugs.webkit.org/show_bug.cgi?id=193907 Source/WebCore: rdar://problem/47604080 Reviewed by Frédéric Wang. Recent scrolling tree changes can trigger unparenting and reparenting of subtrees in the state tree. If a subframe's state tree nodes are unparented, a scrolling tree commit would show these as nodes being destroyed, which destroyed the tree nodes. When re-parented, the commit would re-create the tree node, but the state node would only have a subset of the change flags set, so the new tree node would fail to get all of the state (for example, it would be missing layers and scrolling geometry). Fix by ensuring that when we reparent state node subtrees, we set all the change flags so that the full set of data is sent to the scrolling tree (the UI process, in the case of iOS WK2). Annoyingly, virtual setAllPropertiesChanged() functions are needed so each state node subclass can set the right change flags. This patch also gets rid of m_nodesRemovedSinceLastCommit in the state tree. We can gain the same information by using copying all of the nodeIDs in m_nodeMap into a HashSet, and removing nodes as we encounter them in the tree walk. Rename m_latchedNode to m_latchedNodeID in ScrollingTree, since it's a nodeID, not a node pointer. Test: compositing/geometry/composited-frame-contents.html * page/scrolling/ScrollingStateFixedNode.cpp: (WebCore::ScrollingStateFixedNode::setAllPropertiesChanged): * page/scrolling/ScrollingStateFixedNode.h: * page/scrolling/ScrollingStateFrameScrollingNode.cpp: (WebCore::ScrollingStateFrameScrollingNode::setAllPropertiesChanged): * page/scrolling/ScrollingStateFrameScrollingNode.h: * page/scrolling/ScrollingStateNode.cpp: (WebCore::ScrollingStateNode::setPropertyChanged): (WebCore::ScrollingStateNode::setAllPropertiesChanged): * page/scrolling/ScrollingStateNode.h: (WebCore::ScrollingStateNode::setPropertyChangedBit): * page/scrolling/ScrollingStateScrollingNode.cpp: (WebCore::ScrollingStateScrollingNode::setAllPropertiesChanged): * page/scrolling/ScrollingStateScrollingNode.h: * page/scrolling/ScrollingStateStickyNode.cpp: (WebCore::ScrollingStateStickyNode::setAllPropertiesChanged): * page/scrolling/ScrollingStateStickyNode.h: * page/scrolling/ScrollingStateTree.cpp: (WebCore::ScrollingStateTree::insertNode): Add a RELEASE_ASSERT on the type of the node created if parentID == 0, since mistakes here can associate a ScrollingNodeType::MainFrame node with some other nodeID which can result in type confusion later. (WebCore::ScrollingStateTree::nodeWasReattachedRecursive): (WebCore::ScrollingStateTree::commit): (WebCore::ScrollingStateTree::willRemoveNode): (WebCore::ScrollingStateTree::setRemovedNodes): Deleted. * page/scrolling/ScrollingStateTree.h: (WebCore::ScrollingStateTree::removedNodes const): Deleted. * page/scrolling/ScrollingTree.cpp: (WebCore::ScrollingTree::shouldHandleWheelEventSynchronously): (WebCore::ScrollingTree::commitTreeState): (WebCore::ScrollingTree::updateTreeFromStateNode): (WebCore::ScrollingTree::latchedNode): (WebCore::ScrollingTree::setLatchedNode): (WebCore::ScrollingTree::clearLatchedNode): (WebCore::ScrollingTree::scrollingTreeAsText): (WebCore::ScrollingTree::removeDestroyedNodes): Deleted. * page/scrolling/ScrollingTree.h: (WebCore::ScrollingTree::hasLatchedNode const): * rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::ensureRootLayer): The scroll layer needs a 0,0,0 anchor point so that setting its position doesn't offset it relative to the center. Source/WebKit: Reviewed by Frédéric Wang. Remove encode/decode of removedNodes. * Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp: (WebKit::RemoteScrollingCoordinatorTransaction::encode const): (WebKit::RemoteScrollingCoordinatorTransaction::decode): (WebKit::dump): LayoutTests: rdar://problem/47604080 Reviewed by Frédéric Wang. New ref test for layer positions in composited frames. New baselines with anchor point on the scroll layer. * compositing/geometry/composited-frame-contents-expected.html: Added. * compositing/geometry/composited-frame-contents.html: Added. * compositing/iframes/become-composited-nested-iframes-expected.txt: * compositing/iframes/become-overlapped-iframe-expected.txt: * compositing/iframes/composited-parent-iframe-expected.txt: * compositing/iframes/connect-compositing-iframe-delayed-expected.txt: * compositing/iframes/connect-compositing-iframe-expected.txt: * compositing/iframes/connect-compositing-iframe2-expected.txt: * compositing/iframes/connect-compositing-iframe3-expected.txt: * compositing/iframes/enter-compositing-iframe-expected.txt: * compositing/iframes/iframe-resize-expected.txt: * compositing/iframes/iframe-size-from-zero-expected.txt: * compositing/iframes/overlapped-iframe-expected.txt: * compositing/iframes/overlapped-iframe-iframe-expected.txt: * compositing/iframes/overlapped-nested-iframes-expected.txt: * compositing/iframes/page-cache-layer-tree-expected.txt: * compositing/iframes/remove-reinsert-webview-with-iframe-expected.txt: * compositing/iframes/resize-from-zero-size-expected.txt: * compositing/iframes/scrolling-iframe-expected.txt: * compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt: * compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-expected.txt: * compositing/visible-rect/iframe-with-layers-outside-viewport-expected.txt: * platform/ios-wk2/compositing/iframes/composited-parent-iframe-expected.txt: * platform/ios-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: * platform/ios-wk2/compositing/iframes/connect-compositing-iframe-expected.txt: * platform/ios-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt: * platform/ios-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt: * platform/ios-wk2/compositing/iframes/enter-compositing-iframe-expected.txt: * platform/ios-wk2/compositing/iframes/iframe-resize-expected.txt: * platform/ios-wk2/compositing/iframes/leave-compositing-iframe-expected.txt: * platform/ios-wk2/compositing/iframes/overlapped-iframe-expected.txt: * platform/ios-wk2/compositing/iframes/page-cache-layer-tree-expected.txt: * platform/ios-wk2/compositing/iframes/scrolling-iframe-expected.txt: * platform/ios-wk2/compositing/rtl/rtl-iframe-absolute-expected.txt: * platform/ios-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: * platform/ios-wk2/compositing/rtl/rtl-iframe-fixed-expected.txt: * platform/ios-wk2/compositing/rtl/rtl-iframe-relative-expected.txt: * platform/ios-wk2/compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt: * platform/ios-wk2/compositing/visible-rect/iframe-and-layers-expected.txt: * platform/ios-wk2/scrollingcoordinator/scrolling-tree/fixed-inside-frame-expected.txt: * platform/ios/compositing/iframes/become-composited-nested-iframes-expected.txt: * platform/ios/compositing/iframes/become-overlapped-iframe-expected.txt: * platform/ios/compositing/iframes/invisible-nested-iframe-show-expected.txt: * platform/ios/compositing/iframes/overlapped-nested-iframes-expected.txt: * platform/ios/compositing/iframes/remove-reinsert-webview-with-iframe-expected.txt: * platform/ios/compositing/iframes/resizer-expected.txt: * platform/ios/compositing/visible-rect/iframe-with-layers-outside-viewport-expected.txt: * platform/mac-wk1/compositing/iframes/remove-reinsert-webview-with-iframe-expected.txt: * platform/mac-wk1/compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt: * platform/mac-wk1/compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-expected.txt: * platform/mac-wk2/compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt: * platform/mac/compositing/iframes/invisible-nested-iframe-show-expected.txt: * platform/mac/compositing/iframes/resizer-expected.txt: * platform/mac/compositing/visible-rect/iframe-and-layers-expected.txt: * scrollingcoordinator/scrolling-tree/fixed-inside-frame-expected.txt: * tiled-drawing/tile-coverage-iframe-to-zero-coverage-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@240677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit is a cross-platform web browser engine. On iOS and macOS, it powers Safari, Mail, iBooks, and many other applications.
Visit WebKit Feature Status page to see which Web API has been implemented, in development, or under consideration.
On macOS, download Safari Technology Preview to test the latest version of WebKit. On Linux, download Epiphany Technology Preview. On Windows, you'll have to build it yourself.
Once your bug is filed, you will receive email when it is updated at each stage in the bug life cycle. After the bug is considered fixed, you may be asked to download the latest nightly and confirm that the fix works for you.
On Windows, follow the instructions on our website.
Run the following command to clone WebKit's Git SVN repository:
git clone git://git.webkit.org/WebKit.git WebKit
or
git clone https://git.webkit.org/git/WebKit.git WebKit
If you want to be able to commit changes to the repository, or just want to check out branches that aren’t contained in WebKit.git, you will need track WebKit's Subversion repository. You can run the following command to configure this and other options of the new Git clone for WebKit development.
Tools/Scripts/webkit-patch setup-git-clone
For information about this, and other aspects of using Git with WebKit, read the wiki page.
If you don‘t want to use Git, run the following command to check out WebKit’s Subversion repository:
svn checkout https://svn.webkit.org/repository/webkit/trunk WebKit
Install Xcode and its command line tools if you haven't done so already:
xcode-select --installRun the following command to build a debug build with debugging symbols and assertions:
Tools/Scripts/build-webkit --debug
For performance testing, and other purposes, use --release instead.
You can open WebKit.xcworkspace to build and debug WebKit within Xcode.
If you don't use a custom build location in Xcode preferences, you have to update the workspace settings to use WebKitBuild directory. In menu bar, choose File > Workspace Settings, then click the Advanced button, select “Custom”, “Relative to Workspace”, and enter WebKitBuild for both Products and Intermediates.
The first time after you install a new Xcode, you will need to run the following command to enable Xcode to build command line tools for iOS Simulator:
sudo Tools/Scripts/configure-xcode-for-ios-development
Without this step, you will see the error message: “target specifies product type ‘com.apple.product-type.tool’, but there’s no such product type for the ‘iphonesimulator’ platform.” when building target JSCLLIntOffsetsExtractor of project JavaScriptCore.
Run the following command to build a debug build with debugging symbols and assertions for iOS:
Tools/Scripts/build-webkit --debug --ios-simulator.
For production builds:
cmake -DPORT=GTK -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/gtk/install-dependencies Tools/Scripts/update-webkitgtk-libs Tools/Scripts/build-webkit --gtk --debug
For more information on building WebKitGTK+, see the wiki page.
For production builds:
cmake -DPORT=WPE -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/wpe/install-dependencies Tools/Scripts/update-webkitwpe-libs Tools/Scripts/build-webkit --wpe --debug
For building WebKit on Windows, see the wiki page.
Run the following command to launch Safari with your local build of WebKit:
Tools/Scripts/run-safari --debug
The run-safari script sets the DYLD_FRAMEWORK_PATH environment variable to point to your build products, and then launches /Applications/Safari.app. DYLD_FRAMEWORK_PATH tells the system loader to prefer your build products over the frameworks installed in /System/Library/Frameworks.
To run other applications with your local build of WebKit, run the following command:
Tools/Scripts/run-webkit-app <application-path>
Run the following command to launch iOS simulator with your local build of WebKit:
run-safari --debug --ios-simulator
In both cases, if you have built release builds instead, use --release instead of --debug.
If you have a development build, you can use the run-minibrowser script, e.g.:
run-minibrowser --debug --wpe
Pass one of --gtk, --jsc-only, or --wpe to indicate the port to use.
Congratulations! You’re up and running. Now you can begin coding in WebKit and contribute your fixes and new features to the project. For details on submitting your code to the project, read Contributing Code.