tree 0e58c427f36a6e5540adcfd8ac8a2df034aa97c6
parent e2215c636f9482fd3c9394eaed08912946d4b712
author bdash <bdash@268f45cc-cd09-0410-ab3c-d52691b4dbfc> 1169811351 +0000
committer bdash <bdash@268f45cc-cd09-0410-ab3c-d52691b4dbfc> 1169811351 +0000

2007-01-26  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Reviewed by Darin and Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=10983
          REGRESSION (r12290): Drop shadow of flickr photo note is positioned incorrectly the second time it's shown

        Test: fast/dynamic/staticY.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutPositionedObjects): Avoid marking the object's
        parents, since they have already been laid out.
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::setStaticY): Added a call to setChildNeedsLayout() to
        ensure relayout by this box's container (third and fourth cases in the
        layout test).
        * rendering/RenderBox.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::markContainingBlocksForLayout): For positioned objects
        with static y, also mark the object's parent to ensure that it recomputes
        the static y value (first case in the layout test).

2007-01-26  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin and Maciej.

        - test for http://bugs.webkit.org/show_bug.cgi?id=10983
          REGRESSION (r12290): Drop shadow of flickr photo note is positioned incorrectly the second time it's shown

        Tests three cases that the patch fixes and another one that was fixed in
        r8284 but did not have a test.

        * fast/dynamic/staticY-expected.checksum: Added.
        * fast/dynamic/staticY-expected.png: Added.
        * fast/dynamic/staticY-expected.txt: Added.
        * fast/dynamic/staticY.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19148 268f45cc-cd09-0410-ab3c-d52691b4dbfc