[mac-wk1] Layout test webrtc/datachannel/bufferedAmountLowThreshold tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=177462
Patch by Youenn Fablet <youenn@apple.com> on 2017-09-28
Reviewed by Alex Christensen.
* webrtc/datachannel/bufferedAmountLowThreshold-default.html: Filling buffer until bufferedAmount is bug enough to trigger bufferedAmountLow event.
* webrtc/datachannel/bufferedAmountLowThreshold-expected.txt:
* webrtc/datachannel/bufferedAmountLowThreshold.html: Removing test that is inherently flaky on bots that are not fast enough
to continue filling the webrtc data channel buffer.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@222616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index a30d2cd..86565b0 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,15 @@
+2017-09-28 Youenn Fablet <youenn@apple.com>
+
+ [mac-wk1] Layout test webrtc/datachannel/bufferedAmountLowThreshold tests are flaky
+ https://bugs.webkit.org/show_bug.cgi?id=177462
+
+ Reviewed by Alex Christensen.
+
+ * webrtc/datachannel/bufferedAmountLowThreshold-default.html: Filling buffer until bufferedAmount is bug enough to trigger bufferedAmountLow event.
+ * webrtc/datachannel/bufferedAmountLowThreshold-expected.txt:
+ * webrtc/datachannel/bufferedAmountLowThreshold.html: Removing test that is inherently flaky on bots that are not fast enough
+ to continue filling the webrtc data channel buffer.
+
2017-09-28 Chris Dumez <cdumez@apple.com>
Add support for <link rel=preconnect>
diff --git a/LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold-default.html b/LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold-default.html
index 81b4cb2..0b8b9e5 100644
--- a/LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold-default.html
+++ b/LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold-default.html
@@ -28,9 +28,8 @@
function sendMessages(channel)
{
- channel.send(longString);
- channel.send(longString);
- channel.send(longString);
+ while(channel.bufferedAmount < 1000)
+ channel.send(longString);
}
function receiveMessages(event) {
diff --git a/LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold-expected.txt b/LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold-expected.txt
index 211f313..5844493 100644
--- a/LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold-expected.txt
+++ b/LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold-expected.txt
@@ -1,4 +1,3 @@
PASS Large buffer threshold reached
-PASS Medium buffer threshold not reached
diff --git a/LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold.html b/LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold.html
index 24d27ad..19507ab 100644
--- a/LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold.html
+++ b/LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold.html
@@ -66,29 +66,6 @@
closeDataChannels();
});
}, "Large buffer threshold reached");
-
-promise_test((test) => {
- counter = 0;
- var gotEvent = false;
- return new Promise((resolve, reject) => {
- createConnections((localConnection) => {
- localChannel = localConnection.createDataChannel('sendDataChannel');
- localChannel.onopen = () => {
- sendContinuouslyMessages(localChannel);
- localChannel.onbufferedamountlow = () => {
- reject();
- }
- };
- localChannel.bufferedAmountLowThreshold = 10;
- }, (remoteConnection) => {
- remoteConnection.ondatachannel = (event) => {
- remoteChannel = event.channel;
- remoteChannel.onmessage = receiveMessages;
- };
- });
- setTimeout(resolve, 50);
- });
-}, "Medium buffer threshold not reached");
</script>
</body>
</html>
