WebCore:
2008-11-20 Darin Adler <darin@apple.com>
Earlier version reviewed by Justin Garcia.
- fix <rdar://problem/4108572> REGRESSION: Can't extend selection with shift-arrow in read only mode
* editing/Editor.cpp:
(WebCore::Editor::handleKeyboardEvent): Remove isContentEditable check -- keyboard events can be
handled even when the selection is not in an editable area.
(WebCore::Editor::handleInputMethodKeydown): Ditto.
* editing/EditorCommand.cpp: Changed the enabled rule for operations that change the selection to
allow use when there's a selection even if it's not in an editable area. This includes commands
like shift-arrow keys to extend the slection, but not commands like arrow keys to move the
insertion point.
WebKit/mac:
2008-11-20 Darin Adler <darin@apple.com>
Earlier version reviewed by Justin Garcia.
- part of fix for <rdar://problem/4108572> REGRESSION: Can't extend selection with shift-arrow in read only mode
Also resolves <rdar://problem/5000134>.
* WebView/WebHTMLView.mm: Removed some unused code, and made the Tiger workaround for bug 3789278
be Tiger-only.
(-[WebHTMLView resignFirstResponder]): Removed code setting unused resigningFirstResponder flag.
(-[WebHTMLView _wantsKeyDownForEvent:]): Added. Returns YES.
(-[WebHTMLView insertText:]): Don't try to insert text if the selection is not editable. We used
to prevent even processing the input, but that's not practical since some commands need to work
even in non-editable regions.
LayoutTests:
2008-11-20 Darin Adler <darin@apple.com>
- update test result for <rdar://problem/4108572> REGRESSION: Can't extend
selection with shift-arrow in read only mode
* editing/selection/selection-actions.html: Removed the actions that are
supposed to modify selections now.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
7 files changed
