| commit | 6ddf72b170615ecec95a6e91c205227cc12d556b | [log] [tgz] |
|---|---|---|
| author | pangle@apple.com <pangle@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Tue Jun 21 23:22:07 2022 +0000 |
| committer | pangle@apple.com <pangle@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Tue Jun 21 23:22:07 2022 +0000 |
| tree | 61558d2104ea2d433d950a88b585f241431dd138 | |
| parent | c19171a123537df24000c2385ff2300a0c5e6314 [diff] |
Web Inspector: Fonts details sidebar in Elements tab has empty space for filter bar https://bugs.webkit.org/show_bug.cgi?id=241817 rdar://problem/95634156 Reviewed by Devin Rousso. As pointed out by Devin, passing undefined to `toggle` here acts as if we didn't pass a value, not as a falsy value. * Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js: (WI.GeneralStyleDetailsSidebarPanel.prototype._showPanel): Canonical link: https://commits.webkit.org/251703@main git-svn-id: http://svn.webkit.org/repository/webkit/trunk@295699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js b/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js index 6988428..7403b9f 100644 --- a/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js +++ b/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js
@@ -213,7 +213,7 @@ _showPanel() { this.contentView.addSubview(this._panel); - this.contentView.element.classList.toggle("has-filter-bar", this._filterBar); + this.contentView.element.classList.toggle("has-filter-bar", !!this._filterBar); if (this._filterBar) this.contentView.element.classList.toggle(WI.GeneralStyleDetailsSidebarPanel.FilterInProgressClassName, this._filterBar.hasActiveFilters()); }