commit 6b09aa6a973cad8b5eb558b069f31171c7e46c2d
author tony@chromium.org <tony@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Fri Jun 24 06:43:34 2011 +0000
committer tony@chromium.org <tony@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Fri Jun 24 06:43:34 2011 +0000
tree f520844e60e55c9ddc16781d736d9913b8628335
parent 5189c7cd20695f8ca974ae86ae0a2bab6d9b9b55

2011-06-23  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        Pass Strings by const reference in bindings code
        https://bugs.webkit.org/show_bug.cgi?id=63302

        Note that since Strings hold a RefPtr to StringImpl, passing Strings
        by value isn't horrible, but it does cause ref count churn and using
        const references is more consistent with the rest of the code base.

        * bindings/generic/BindingSecurity.h:
        (WebCore::::allowSettingFrameSrcToJavascriptUrl):
        (WebCore::::allowSettingSrcToJavascriptURL):
        * bindings/js/SerializedScriptValue.cpp:
        (WebCore::CloneSerializer::serialize):
        (WebCore::SerializedScriptValue::create):
        * bindings/js/SerializedScriptValue.h:
        * bindings/v8/SerializedScriptValue.cpp:
        (WebCore::SerializedScriptValue::createFromWire):
        (WebCore::SerializedScriptValue::create):
        (WebCore::SerializedScriptValue::SerializedScriptValue):
        * bindings/v8/SerializedScriptValue.h:
        * bindings/v8/V8Binding.h:
        (WebCore::V8ParameterBase::setString):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/bindings/js/SerializedScriptValue.cpp

diff --git a/Source/WebCore/bindings/js/SerializedScriptValue.cpp b/Source/WebCore/bindings/js/SerializedScriptValue.cpp
index 74bcbba..e407f87 100644
--- a/Source/WebCore/bindings/js/SerializedScriptValue.cpp
+++ b/Source/WebCore/bindings/js/SerializedScriptValue.cpp
@@ -256,7 +256,7 @@
         return serializer.serialize(value);
     }
 
-    static bool serialize(String s, Vector<uint8_t>& out)
+    static bool serialize(const String& s, Vector<uint8_t>& out)
     {
         writeLittleEndian(out, CurrentVersion);
         if (s.isEmpty()) {
@@ -1357,7 +1357,7 @@
     return adoptRef(new SerializedScriptValue(buffer));
 }
 
-PassRefPtr<SerializedScriptValue> SerializedScriptValue::create(String string)
+PassRefPtr<SerializedScriptValue> SerializedScriptValue::create(const String& string)
 {
     Vector<uint8_t> buffer;
     if (!CloneSerializer::serialize(string, buffer))