tree 9762de81897e91f9c55b5e22f0c5a657377ea254
parent bb9e441eedbf4e66961eabddfbfe53041b330668
author megan_gardner@apple.com <megan_gardner@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> 1579313596 +0000
committer megan_gardner@apple.com <megan_gardner@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> 1579313596 +0000

Use Visible Position to calculate Positions for highlights
https://bugs.webkit.org/show_bug.cgi?id=206314

Reviewed by Ryosuke Niwa.

Source/WebCore:

When after layout is complete create a VisibleSelection from and highlight StaticRanges which
don't have position data yet. This will make sure that the information is availble when
rendering, as Visible Positions and Visible Selections cannot be made while rendering.
Also, add the ability to make a VisibleSelection from a Static Range to simplify the code.

Updated Test:
* LayoutTests/http/wpt/css/css-highlight-api/highlight-text-across-elements.html:
* LayoutTests/http/wpt/css/css-highlight-api/highlight-text-cascade.html:
* LayoutTests/http/wpt/css/css-highlight-api/highlight-text-replace.html:
* LayoutTests/http/wpt/css/css-highlight-api/highlight-text.html:

* Modules/highlight/HighlightRangeGroup.cpp:
(WebCore::HighlightRangeGroup::HighlightRangeGroup):
(WebCore::HighlightRangeGroup::create):
(WebCore::HighlightRangeGroup::initializeSetLike):
(WebCore::HighlightRangeGroup::removeFromSetLike):
(WebCore::HighlightRangeGroup::clearFromSetLike):
(WebCore::HighlightRangeGroup::addToSetLike):
* Modules/highlight/HighlightRangeGroup.h:
(WebCore::HighlightRangeData::create):
(WebCore::HighlightRangeData::HighlightRangeData):
(WebCore::HighlightRangeGroup::rangesData const):
(WebCore::HighlightRangeGroup::ranges const): Deleted.
* Modules/highlight/HighlightRangeGroup.idl:
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::create):
* editing/VisibleSelection.h:
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::collectMarkedTextsForHighlights const):
* rendering/SelectionRangeData.cpp:
(WebCore::SelectionRangeData::selectionStateForRenderer):

LayoutTests:

* highlight/resources/highlight-frame.html:
* http/wpt/css/css-highlight-api/highlight-text-across-elements.html:
* http/wpt/css/css-highlight-api/highlight-text-cascade.html:
* http/wpt/css/css-highlight-api/highlight-text-replace.html:
* http/wpt/css/css-highlight-api/highlight-text.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@254785 268f45cc-cd09-0410-ab3c-d52691b4dbfc