commit | 51f4fbb4bada3a97e2c048a2780f1666f878e24f | [log] [tgz] |
---|---|---|
author | wenson_hsieh@apple.com <wenson_hsieh@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Fri Oct 18 14:24:07 2019 +0000 |
committer | wenson_hsieh@apple.com <wenson_hsieh@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Fri Oct 18 14:24:07 2019 +0000 |
tree | 579a4a9e372ef83f626e9c19710079e0e850f24c | |
parent | 8c7ab9de3352b85badebd1b3d221774191ea4251 [diff] |
[Clipboard API] Support navigator.clipboard.read() https://bugs.webkit.org/show_bug.cgi?id=203021 Reviewed by Ryosuke Niwa. LayoutTests/imported/w3c: Rebaseline a web platform test, now that Clipboard.read() no longer immediately rejects. * web-platform-tests/clipboard-apis/async-navigator-clipboard-basics.https-expected.txt: Source/WebCore: Add support for navigator.clipboard.read(), which returns a promise that resolves to a list of ClipboardItems. See below for more details. Tests: editing/async-clipboard/clipboard-change-data-while-reading.html editing/async-clipboard/clipboard-read-basic.html * Modules/async-clipboard/Clipboard.cpp: (WebCore::Clipboard::read): Implement read(). This makes two calls to the platform pasteboard: the first to get the current change count, and if the change count is different from the changeCount used for the last read() call (or there are no existing clipboard items being tracked), then we request pasteboard item information for all items on the pasteboard, and use this information to create new clipboard items. Otherwise, if the changeCount is still valid for the current list of clipboard items, simply return these clipboard items. If the changeCount ends up being different in between the initial changeCount request and when the pasteboard item information is received, we immediately bail with a NotAllowedError. The new layout test clipboard-change-data-while-reading.html exercises this scenario. (WebCore::Clipboard::getType): (WebCore::Clipboard::frame const): * Modules/async-clipboard/Clipboard.h: * Modules/async-clipboard/ClipboardItem.cpp: (WebCore::ClipboardItem::blobFromString): (WebCore::ClipboardItem::ClipboardItem): (WebCore::ClipboardItem::create): (WebCore::ClipboardItem::navigator): Refactor this so that each clipboard item itself has a WeakPtr to its Navigator. This avoids having to follow the weak pointer to the Clipboard to get to the Clipboard's navigator during garbage collection when computing reachability from opaque roots, since this may happen on a background (GC) thread. (WebCore::ClipboardItem::clipboard): * Modules/async-clipboard/ClipboardItem.h: * Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp: (WebCore::ClipboardItemBindingsDataSource::getType): (WebCore::blobFromString): Deleted. Move this to ClipboardItem, and make it a static method. * Modules/async-clipboard/ClipboardItemPasteboardDataSource.cpp: (WebCore::ClipboardItemPasteboardDataSource::ClipboardItemPasteboardDataSource): (WebCore::ClipboardItemPasteboardDataSource::getType): * Modules/async-clipboard/ClipboardItemPasteboardDataSource.h: Move a couple of member variables (index and changeCount) out of ClipboardItem. Instead of having each ClipboardItem keep track of this information, have the Clipboard that owns the ClipboardItem keep this information. This means that reading data from ClipboardItem will (in a future patch) work by having the item ask its Clipboard object to read data on its behalf. * platform/Pasteboard.cpp: (WebCore::Pasteboard::allPasteboardItemInfo const): (WebCore::Pasteboard::pasteboardItemInfo const): (WebCore::Pasteboard::readString): (WebCore::Pasteboard::readBuffer): (WebCore::Pasteboard::readURL): Add some null checks to handle the case where there is no pasteboard strategy. Tools: Make adjustments to WebKitTestRunner and DumpRenderTree to support the new layout tests. See below for more details. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/mac/DumpRenderTreePasteboard.mm: (-[LocalPasteboard pasteboardItems]): Fixes an existing issue with the mock NSPasteboard used for layout tests. Currently, our logic for converting the contents of the platform pasteboard to NSPasteboardItem simply writes the pasteboard data as-is to NSPasteboardItems. However, these pasteboard types may be legacy pasteboard types, in which case NSPasteboardItem will simply handle the call to `-setData:forType:` as a no-op. AppKit has logic in this scenario to canonicalize these legacy pasteboard types to their modern counterparts, but this is absent in DumpRenderTreePasteboard and WebKitTestRunnerPasteboard. Address this by teaching the mock pasteboards to convert legacy types to modern types when generating platform pasteboard items. * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: * TestRunnerShared/UIScriptContext/UIScriptController.h: (WTR::UIScriptController::copyText): Add a new UIScriptController method to write a string to the platform pasteboard. This patch adds support for this new testing hook on macOS and iOS, in WebKit2 (WebKitTestRunner). * TestRunnerShared/mac/NSPasteboardAdditions.h: Copied from Tools/WebKitTestRunner/mac/UIScriptControllerMac.h. * TestRunnerShared/mac/NSPasteboardAdditions.mm: Added. (+[NSPasteboard _modernPasteboardType:]): Add a helper to convert legacy pasteboard types (and dynamic UTIs that map to legacy pasteboard types) to modern pasteboard types, suitable for writing to NSPasteboardItems on macOS. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: * WebKitTestRunner/ios/UIScriptControllerIOS.h: * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptControllerIOS::copyText): * WebKitTestRunner/mac/UIScriptControllerMac.h: * WebKitTestRunner/mac/UIScriptControllerMac.mm: (WTR::UIScriptControllerMac::copyText): * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Apply the same fix for WebKitTestRunner's mock NSPasteboard. (-[LocalPasteboard _clearContentsWithoutUpdatingChangeCount]): (-[LocalPasteboard clearContents]): Make -clearContents clear out all the contents on the mock pasteboard, instead of crashing in AppKit. (-[LocalPasteboard declareTypes:owner:]): (-[LocalPasteboard pasteboardItems]): LayoutTests: * editing/async-clipboard/clipboard-change-data-while-reading-expected.txt: Added. * editing/async-clipboard/clipboard-change-data-while-reading.html: Added. Add a new layout test to verify that if the platform pasteboard changes in the middle of a DOM paste access request, the promise returned by Clipboard.read() should reject, and the page should not receive any clipboard items. * editing/async-clipboard/clipboard-read-basic-expected.txt: Added. * editing/async-clipboard/clipboard-read-basic.html: Added. Add a new layout test to exercise Clipboard.read(). Since we don't support reading data from clipboard items yet, this only checks the types of each pasteboard item. This test additionally ensures that the ClipboardItems returned from the API are the same between calls to Clipboard.read() if the data hasn't changed. * editing/async-clipboard/resources/async-clipboard-helpers.js: (writeToClipboardUsingDataTransfer): Add a new helper to synchronously write data to the clipboard using execCommand and DataTransfer API. (async.triggerProgrammaticPaste): Add a new helper to trigger programmatic paste by activating the given element or location. Also receives an array of options (which, for now, just supports a single option to change the pasteboard when granting DOM paste access). * platform/ios-wk1/TestExpectations: Skip clipboard-change-data-while-reading.html for now in WebKit1. * platform/mac-wk1/TestExpectations: Skip clipboard-change-data-while-reading.html for now in WebKit1. * platform/win/TestExpectations: Skip the new layout tests on Windows for now. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@251279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit is a cross-platform web browser engine. On iOS and macOS, it powers Safari, Mail, iBooks, and many other applications.
Visit WebKit Feature Status page to see which Web API has been implemented, in development, or under consideration.
On macOS, download Safari Technology Preview to test the latest version of WebKit. On Linux, download Epiphany Technology Preview. On Windows, you'll have to build it yourself.
Once your bug is filed, you will receive email when it is updated at each stage in the bug life cycle. After the bug is considered fixed, you may be asked to download the latest nightly and confirm that the fix works for you.
On Windows, follow the instructions on our website.
Run the following command to clone WebKit's Git SVN repository:
git clone git://git.webkit.org/WebKit.git WebKit
or
git clone https://git.webkit.org/git/WebKit.git WebKit
If you want to be able to commit changes to the repository, or just want to check out branches that aren’t contained in WebKit.git, you will need track WebKit's Subversion repository. You can run the following command to configure this and other options of the new Git clone for WebKit development.
Tools/Scripts/webkit-patch setup-git-clone
For information about this, and other aspects of using Git with WebKit, read the wiki page.
If you don‘t want to use Git, run the following command to check out WebKit’s Subversion repository:
svn checkout https://svn.webkit.org/repository/webkit/trunk WebKit
Install Xcode and its command line tools if you haven't done so already:
xcode-select --install
Run the following command to build a debug build with debugging symbols and assertions:
Tools/Scripts/build-webkit --debug
For performance testing, and other purposes, use --release
instead.
You can open WebKit.xcworkspace
to build and debug WebKit within Xcode.
If you don't use a custom build location in Xcode preferences, you have to update the workspace settings to use WebKitBuild
directory. In menu bar, choose File > Workspace Settings, then click the Advanced button, select “Custom”, “Relative to Workspace”, and enter WebKitBuild
for both Products and Intermediates.
The first time after you install a new Xcode, you will need to run the following command to enable Xcode to build command line tools for iOS Simulator:
sudo Tools/Scripts/configure-xcode-for-ios-development
Without this step, you will see the error message: “target specifies product type ‘com.apple.product-type.tool’, but there’s no such product type for the ‘iphonesimulator’ platform.
” when building target JSCLLIntOffsetsExtractor
of project JavaScriptCore
.
Run the following command to build a debug build with debugging symbols and assertions for iOS:
Tools/Scripts/build-webkit --debug --ios-simulator
For production builds:
cmake -DPORT=GTK -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/gtk/install-dependencies Tools/Scripts/update-webkitgtk-libs Tools/Scripts/build-webkit --gtk --debug
For more information on building WebKitGTK+, see the wiki page.
For production builds:
cmake -DPORT=WPE -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/wpe/install-dependencies Tools/Scripts/update-webkitwpe-libs Tools/Scripts/build-webkit --wpe --debug
For building WebKit on Windows, see the wiki page.
Run the following command to launch Safari with your local build of WebKit:
Tools/Scripts/run-safari --debug
The run-safari
script sets the DYLD_FRAMEWORK_PATH
environment variable to point to your build products, and then launches /Applications/Safari.app
. DYLD_FRAMEWORK_PATH
tells the system loader to prefer your build products over the frameworks installed in /System/Library/Frameworks
.
To run other applications with your local build of WebKit, run the following command:
Tools/Scripts/run-webkit-app <application-path>
Run the following command to launch iOS simulator with your local build of WebKit:
run-safari --debug --ios-simulator
In both cases, if you have built release builds instead, use --release
instead of --debug
.
If you have a development build, you can use the run-minibrowser script, e.g.:
run-minibrowser --debug --wpe
Pass one of --gtk
, --jsc-only
, or --wpe
to indicate the port to use.
Congratulations! You’re up and running. Now you can begin coding in WebKit and contribute your fixes and new features to the project. For details on submitting your code to the project, read Contributing Code.