tree 590dd40f7144f0aa14bdd0f1a8e74f040029c270
parent 828cdc69b424119b0ff265b02b170b4013c9471f
author jya@apple.com <jya@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> 1643201780 +0000
committer jya@apple.com <jya@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> 1643201780 +0000

REGRESSION(r287684) speedtest.net uses many GB of memory
https://bugs.webkit.org/show_bug.cgi?id=235615
rdar://87830583

Reviewed by Youenn Fablet.

The regression was introduced with r286937 and is a good example of
errors introduced when attempting to optimise things too early.
CachedRawResource::updateBuffer does a search in the accumulating
resource's SharedBuffer, search that was taking O(log(n)+1) prior r286937
where n is the number of DataView segments in the SharedBuffer.
This was simplified as a O(1) operation by using the combined contiguous
SharedBuffer instead.
However, that caused every single intermediary accumulated buffers to be
kept referenced by the XMLHttpRequest SharedBufferBuilder leading to
massive memory use.

* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::updateBuffer):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@288614 268f45cc-cd09-0410-ab3c-d52691b4dbfc