tree 8d20d1cf996d5667bbd5306086208b9fba969588
parent ca46204a64dfefa594ae42a6a6fad102394c0950
author ysuzuki@apple.com <ysuzuki@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> 1574751765 +0000
committer ysuzuki@apple.com <ysuzuki@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> 1574751765 +0000

[JSC] InternalFunction should be non-destructible
https://bugs.webkit.org/show_bug.cgi?id=204556

Reviewed by Mark Lam.

Source/JavaScriptCore:

InternalFunction and most of its subclasses should be non-destructible since they can be trivially
destructed and don't use a destroy function. For the few subclasses that do need a destroy function,
these should have different IsoSubspaces of their own. For each of these subclasses, we annotate
needsDestruction = true, define a specific HeapCellType for them, and pass the HeapCellType to their
IsoSubspace so that their destructors can be invoked.

* API/ObjCCallbackFunction.h:
* API/glib/JSCCallbackFunction.cpp:
(JSC::JSCCallbackFunction::subspaceForImpl): Deleted.
* API/glib/JSCCallbackFunction.h:
(JSC::JSCCallbackFunction::subspaceFor): Deleted.
(JSC::JSCCallbackFunction::createStructure): Deleted.
(JSC::JSCCallbackFunction::functionCallback): Deleted.
(JSC::JSCCallbackFunction::constructCallback): Deleted.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleTypedArrayConstructor):
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::InternalFunction):
* runtime/InternalFunction.h:
* runtime/VM.cpp:
(JSC::VM::VM):
* runtime/VM.h:

Source/WebCore:

* bindings/js/WebCoreJSClientData.cpp:
(WebCore::JSVMClientData::JSVMClientData):

Source/WebKit:

* WebProcess/Plugins/Netscape/JSNPMethod.cpp:
(WebKit::JSNPMethod::subspaceForImpl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@252875 268f45cc-cd09-0410-ab3c-d52691b4dbfc