tree 9c19b29f36857ee056b129ebee52c041f9d009e1
parent f8942ab6d5b140dc902d7b1f5583f16c16278804
author commit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> 1529716924 +0000
committer commit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> 1529716924 +0000

SubresourceLoader::didFail() should only log message if state is Initialized
https://bugs.webkit.org/show_bug.cgi?id=185124

Patch by Woodrow Wang <woodrow_wang@apple.com> on 2018-06-22
Reviewed by Daniel Bates.

Functionality does not change. Moved console logging to be
after checking state of subresource loader. We only need to
log if the state is initialized. This is consistent with other
functions in the file. We can also remove a null check for the
frame pointer (m_frame). The superclass ResourceLoader constructor
takes an lvalue reference and initializes m_frame, ensuring
m_frame cannot be null. It is only set to null by
ResourceLoader::releaseResources(), which is only called after the
resource finishes loading or fails to load. Thus, in didFail(),
m_frame must be non-null when we're logging and up until the end of the function.

* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didFail):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@233117 268f45cc-cd09-0410-ab3c-d52691b4dbfc