commit | 5bcb5ef772cf8b92a5e775b31acbe03187287df2 | [log] [tgz] |
---|---|---|
author | ysuzuki@apple.com <ysuzuki@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Fri May 10 20:49:35 2019 +0000 |
committer | ysuzuki@apple.com <ysuzuki@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Fri May 10 20:49:35 2019 +0000 |
tree | d1dfc19dd053995ed9517ee764e7dd3b80135484 | |
parent | b672b03ebac6e7f06d9d38aa83fd218a1da9eed8 [diff] |
[JSC] String substring operation should return ropes consistently https://bugs.webkit.org/show_bug.cgi?id=197765 <rdar://problem/37689944> Reviewed by Michael Saboff. Currently we have different policies per string substring operation function. 1. String#slice returns the resolved non-rope string 2. String#substring returns rope string 3. String#substr returns rope string in runtime function, non-rope string in DFG and FTL Due to (3), we see large memory use in the tested web page[1]. Non rope substring have a problem. First of all, that returned string seems not used immediately. It is possible that the resulted string is used as a part of the other ropes (like, xxx.substring(...) + "Hello"). To avoid the eager materialization of the string, we are using StringImpl::createSubstringSharingImpl for the resulted non rope string. StringImpl::createSubstringSharingImpl is StringImpl's substring feature: the substring is pointing the owner StringImpl. While this has memory saving benefit, it can retain owner StringImpl so long, and it could keep very large owner StringImpl alive. The problem we are attempting to solve with StringImpl::createSubstringSharingImpl can be solved by the rope string simply. Rope string can share the underlying string. And good feature of the rope string is that, when resolving rope string, the rope string always create a new StringImpl instead of using StringImpl::createSubstringSharingImpl. So we allow the owner StringImpl to be destroyed. And this resolving only happens when we actually want to use the content of the rope string. In addition, we recently shrunk the sizeof(JSRopeString) from 48 to 32, so JSRopeString is cheap. In this patch, we change (2) and (3) to (1), using rope String as a result of substring operations. RAMification and JetStream2 are neutral. The web page[1] shows large memory footprint improvement from 776MB to 681MB. [1]: https://beta.observablehq.com/@ldgardner/assignment-4-visualizations-and-multiple-views * dfg/DFGOperations.cpp: * runtime/StringPrototype.cpp: (JSC::stringProtoFuncSlice): * runtime/StringPrototypeInlines.h: (JSC::stringSlice): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@245194 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit is a cross-platform web browser engine. On iOS and macOS, it powers Safari, Mail, iBooks, and many other applications.
Visit WebKit Feature Status page to see which Web API has been implemented, in development, or under consideration.
On macOS, download Safari Technology Preview to test the latest version of WebKit. On Linux, download Epiphany Technology Preview. On Windows, you'll have to build it yourself.
Once your bug is filed, you will receive email when it is updated at each stage in the bug life cycle. After the bug is considered fixed, you may be asked to download the latest nightly and confirm that the fix works for you.
On Windows, follow the instructions on our website.
Run the following command to clone WebKit's Git SVN repository:
git clone git://git.webkit.org/WebKit.git WebKit
or
git clone https://git.webkit.org/git/WebKit.git WebKit
If you want to be able to commit changes to the repository, or just want to check out branches that aren’t contained in WebKit.git, you will need track WebKit's Subversion repository. You can run the following command to configure this and other options of the new Git clone for WebKit development.
Tools/Scripts/webkit-patch setup-git-clone
For information about this, and other aspects of using Git with WebKit, read the wiki page.
If you don‘t want to use Git, run the following command to check out WebKit’s Subversion repository:
svn checkout https://svn.webkit.org/repository/webkit/trunk WebKit
Install Xcode and its command line tools if you haven't done so already:
xcode-select --install
Run the following command to build a debug build with debugging symbols and assertions:
Tools/Scripts/build-webkit --debug
For performance testing, and other purposes, use --release
instead.
You can open WebKit.xcworkspace
to build and debug WebKit within Xcode.
If you don't use a custom build location in Xcode preferences, you have to update the workspace settings to use WebKitBuild
directory. In menu bar, choose File > Workspace Settings, then click the Advanced button, select “Custom”, “Relative to Workspace”, and enter WebKitBuild
for both Products and Intermediates.
The first time after you install a new Xcode, you will need to run the following command to enable Xcode to build command line tools for iOS Simulator:
sudo Tools/Scripts/configure-xcode-for-ios-development
Without this step, you will see the error message: “target specifies product type ‘com.apple.product-type.tool’, but there’s no such product type for the ‘iphonesimulator’ platform.
” when building target JSCLLIntOffsetsExtractor
of project JavaScriptCore
.
Run the following command to build a debug build with debugging symbols and assertions for iOS:
Tools/Scripts/build-webkit --debug --ios-simulator
For production builds:
cmake -DPORT=GTK -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/gtk/install-dependencies Tools/Scripts/update-webkitgtk-libs Tools/Scripts/build-webkit --gtk --debug
For more information on building WebKitGTK+, see the wiki page.
For production builds:
cmake -DPORT=WPE -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/wpe/install-dependencies Tools/Scripts/update-webkitwpe-libs Tools/Scripts/build-webkit --wpe --debug
For building WebKit on Windows, see the wiki page.
Run the following command to launch Safari with your local build of WebKit:
Tools/Scripts/run-safari --debug
The run-safari
script sets the DYLD_FRAMEWORK_PATH
environment variable to point to your build products, and then launches /Applications/Safari.app
. DYLD_FRAMEWORK_PATH
tells the system loader to prefer your build products over the frameworks installed in /System/Library/Frameworks
.
To run other applications with your local build of WebKit, run the following command:
Tools/Scripts/run-webkit-app <application-path>
Run the following command to launch iOS simulator with your local build of WebKit:
run-safari --debug --ios-simulator
In both cases, if you have built release builds instead, use --release
instead of --debug
.
If you have a development build, you can use the run-minibrowser script, e.g.:
run-minibrowser --debug --wpe
Pass one of --gtk
, --jsc-only
, or --wpe
to indicate the port to use.
Congratulations! You’re up and running. Now you can begin coding in WebKit and contribute your fixes and new features to the project. For details on submitting your code to the project, read Contributing Code.