commit 51491e0ac8ba68c3c854e68dcecc17ae5c03c5e3
author commit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Thu Oct 31 18:47:00 2013 +0000
committer commit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Thu Oct 31 18:47:00 2013 +0000
tree 01deb8c5b23fcef41808ece7a7ee96e16be97106
parent 094c7973ec47070898577ec4b7895f1d43d3f3f6

Decorated text sometimes does not draw its decorations
https://bugs.webkit.org/show_bug.cgi?id=123539

Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-31
Reviewed by Antti Koivisto.

Decorated text should opt-out of the simple line layout, because
SimpleLineLayout::paintFlow doesn't draw decorations

Fixes fast/css3-text/css3-text-decoration/text-decoration-color.html

* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index f02f940..32a4097 100644
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,18 @@
+2013-10-31  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        Decorated text sometimes does not draw its decorations
+        https://bugs.webkit.org/show_bug.cgi?id=123539
+
+        Reviewed by Antti Koivisto.
+
+        Decorated text should opt-out of the simple line layout, because
+        SimpleLineLayout::paintFlow doesn't draw decorations
+
+        Fixes fast/css3-text/css3-text-decoration/text-decoration-color.html
+
+        * rendering/SimpleLineLayout.cpp:
+        (WebCore::SimpleLineLayout::canUseFor):
+
 2013-10-31  Joseph Pecoraro  <pecoraro@apple.com>
 
         Web Inspector: Remove last member variable uses of InspectorState from Agents

Source/WebCore/rendering/SimpleLineLayout.cpp

diff --git a/Source/WebCore/rendering/SimpleLineLayout.cpp b/Source/WebCore/rendering/SimpleLineLayout.cpp
index 5dd46c4..cfbaa8b 100644
--- a/Source/WebCore/rendering/SimpleLineLayout.cpp
+++ b/Source/WebCore/rendering/SimpleLineLayout.cpp
@@ -94,6 +94,8 @@
             return false;
     }
     const RenderStyle& style = flow.style();
+    if (style.textDecorationsInEffect() != TextDecorationNone)
+        return false;
     if (style.textAlign() == JUSTIFY)
         return false;
     // Non-visible overflow should be pretty easy to support.