commit 5146101c9b2e5b7e9828d637551dc781e2a1a908
author commit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Thu Nov 08 23:44:22 2018 +0000
committer commit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Thu Nov 08 23:44:22 2018 +0000
tree 0a49592618ce8dc7c1f1b330632c2f65c8530de3
parent d4a22c01ee1f57861b91d0036fb7f879d3ca0893

Web Inspector: Potential for watch expressions to never show results
https://bugs.webkit.org/show_bug.cgi?id=191438

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2018-11-08
Reviewed by Matt Baker.

* UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
(WI.ScopeChainDetailsSidebarPanel.prototype._generateWatchExpressionsSection):
If there was no object don't bail, continue and resolve the Promise.
In this case we can fallback to show `undefined`. This code might not be
reachable right now, but is wrong as is.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@238005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog

diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
index a49eb73..03171fc 100644
--- a/Source/WebInspectorUI/ChangeLog
+++ b/Source/WebInspectorUI/ChangeLog
@@ -1,5 +1,18 @@
 2018-11-08  Joseph Pecoraro  <pecoraro@apple.com>
 
+        Web Inspector: Potential for watch expressions to never show results
+        https://bugs.webkit.org/show_bug.cgi?id=191438
+
+        Reviewed by Matt Baker.
+
+        * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
+        (WI.ScopeChainDetailsSidebarPanel.prototype._generateWatchExpressionsSection):
+        If there was no object don't bail, continue and resolve the Promise.
+        In this case we can fallback to show `undefined`. This code might not be
+        reachable right now, but is wrong as is.
+
+2018-11-08  Joseph Pecoraro  <pecoraro@apple.com>
+
         Web Inspector: Debugger Popover does not work when paused in Worker
         https://bugs.webkit.org/show_bug.cgi?id=191342