commit 513d26fa1e12bcfed3c803d235dbc89ad0c5509c
author kling@webkit.org <kling@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Mon Aug 06 13:14:04 2012 +0000
committer kling@webkit.org <kling@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Mon Aug 06 13:14:04 2012 +0000
tree c441a8a6a6276b561298be8d7ef242d8c393996b
parent fdb1d92fa9f88fdfaec518f61a1e009b6a30755c

Pass presentational attribute StylePropertySets by const pointer where possible.
<http://webkit.org/b/93187>

Reviewed by Antti Koivisto.

Minor cleanup to enforce (at compile time) the fact that no methods that have the
side-effect of incurring immutable-to-mutable-StylePropertySet conversion.

This was already covered by assertions, we're just making it stricter and adding
some documentational flavor.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::addElementStyleProperties):
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/StyleResolver.h:
(StyleResolver):
* dom/ElementAttributeData.h:
(WebCore::ElementAttributeData::attributeStyle):
* dom/StyledElement.h:
(WebCore::StyledElement::additionalAttributeStyle):
(StyledElement):
(WebCore::StyledElement::attributeStyle):
* html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::additionalAttributeStyle):
* html/HTMLTableCellElement.h:
(HTMLTableCellElement):
* html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::additionalAttributeStyle):
* html/HTMLTableColElement.h:
(HTMLTableColElement):
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::additionalAttributeStyle):
(WebCore::HTMLTableElement::additionalCellStyle):
(WebCore::HTMLTableElement::additionalGroupStyle):
* html/HTMLTableElement.h:
(HTMLTableElement):
* html/HTMLTableSectionElement.cpp:
(WebCore::HTMLTableSectionElement::additionalAttributeStyle):
* html/HTMLTableSectionElement.h:
(HTMLTableSectionElement):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/html/HTMLTableElement.cpp

diff --git a/Source/WebCore/html/HTMLTableElement.cpp b/Source/WebCore/html/HTMLTableElement.cpp
index 6232609..283786b 100644
--- a/Source/WebCore/html/HTMLTableElement.cpp
+++ b/Source/WebCore/html/HTMLTableElement.cpp
@@ -432,7 +432,7 @@
     return style.release().leakRef();
 }
 
-StylePropertySet* HTMLTableElement::additionalAttributeStyle()
+const StylePropertySet* HTMLTableElement::additionalAttributeStyle()
 {
     if (m_frameAttr)
         return 0;
@@ -518,7 +518,7 @@
     return style.release();
 }
 
-StylePropertySet* HTMLTableElement::additionalCellStyle()
+const StylePropertySet* HTMLTableElement::additionalCellStyle()
 {
     if (!m_sharedCellStyle)
         m_sharedCellStyle = createSharedCellStyle();
@@ -542,7 +542,7 @@
     return style.release().leakRef();
 }
 
-StylePropertySet* HTMLTableElement::additionalGroupStyle(bool rows)
+const StylePropertySet* HTMLTableElement::additionalGroupStyle(bool rows)
 {
     if (m_rulesAttr != GroupsRules)
         return 0;