Add StringBuilder::appendNumber() and use it
https://bugs.webkit.org/show_bug.cgi?id=96030
Reviewed by Eric Seidel.
Also fix a bunch of append() vs. appendLiteral() issues in the surrounding code.
Source/JavaScriptCore:
* API/JSContextRef.cpp:
(JSContextCreateBacktrace):
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.h:
(JSC::StackFrame::toString):
Source/WebCore:
* Modules/websockets/WebSocketHandshake.cpp:
(WebCore::hostName):
* bindings/v8/ScriptController.cpp:
(WebCore::resourceString):
* css/FontFeatureValue.cpp:
(WebCore::FontFeatureValue::customCssText):
* dom/Position.cpp:
(WebCore::Position::formatForDebugger):
* dom/Range.cpp:
(WebCore::Range::formatForDebugger):
* html/FormController.cpp:
(WebCore::FormKeyGenerator::formKey):
* html/HTMLAnchorElement.cpp:
(WebCore::appendServerMapMousePosition):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::font):
* inspector/IdentifiersFactory.cpp:
(WebCore::IdentifiersFactory::addProcessIdPrefixTo):
* page/FrameTree.cpp:
(WebCore::FrameTree::uniqueChildName):
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::toRawString):
* platform/Decimal.cpp:
(WebCore::Decimal::toString):
* platform/network/ProxyServer.cpp:
(WebCore::appendProxyServerString):
* platform/text/TextStream.cpp:
(WebCore::TextStream::operator<<):
* platform/text/TextStream.h:
* rendering/RenderTreeAsText.cpp:
(WebCore::nodePosition):
* xml/XMLErrors.cpp:
(WebCore::XMLErrors::appendErrorMessage):
Source/WTF:
* wtf/DateMath.cpp:
(WTF::makeRFC2822DateString):
* wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::appendNumber):
* wtf/text/StringBuilder.h:
(StringBuilder):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128014 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/Source/WebCore/html/FormController.cpp b/Source/WebCore/html/FormController.cpp
index 49412be..e5767e1 100644
--- a/Source/WebCore/html/FormController.cpp
+++ b/Source/WebCore/html/FormController.cpp
@@ -358,8 +358,8 @@
StringBuilder builder;
builder.append(signature);
- builder.append(" #");
- builder.append(String::number(nextIndex));
+ builder.appendLiteral(" #");
+ builder.appendNumber(nextIndex);
AtomicString formKey = builder.toAtomicString();
m_formToKeyMap.add(form, formKey);
return formKey;
diff --git a/Source/WebCore/html/HTMLAnchorElement.cpp b/Source/WebCore/html/HTMLAnchorElement.cpp
index c3299fc..f9e3ebc 100644
--- a/Source/WebCore/html/HTMLAnchorElement.cpp
+++ b/Source/WebCore/html/HTMLAnchorElement.cpp
@@ -145,9 +145,9 @@
int x = absolutePosition.x();
int y = absolutePosition.y();
url.append('?');
- url.append(String::number(x));
+ url.appendNumber(x);
url.append(',');
- url.append(String::number(y));
+ url.appendNumber(y);
}
void HTMLAnchorElement::defaultEventHandler(Event* event)
diff --git a/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp b/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
index a960489..5414bad 100644
--- a/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
+++ b/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
@@ -2001,7 +2001,7 @@
if (fontDescription.smallCaps() == FontSmallCapsOn)
serializedFont.appendLiteral("small-caps ");
- serializedFont.append(String::number(fontDescription.computedPixelSize()));
+ serializedFont.appendNumber(fontDescription.computedPixelSize());
serializedFont.appendLiteral("px");
const FontFamily& firstFontFamily = fontDescription.family();
