CustomConfigurationTestGroupForm should dispatch different arguments based on whether analysis task is created.
https://bugs.webkit.org/show_bug.cgi?id=187675
Reviewed by Ryosuke Niwa.
This change will fix the bug that no notification will be sent for any test groups except the
first one in any custom perf-try A/B task.
* public/v3/components/custom-configuration-test-group-form.js:
(CustomConfigurationTestGroupForm.prototype.startTesting): Conditionally includes taskName based on
whether or not analysis task is created.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@233884 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/Websites/perf.webkit.org/ChangeLog b/Websites/perf.webkit.org/ChangeLog
index 44fb9ce..c127a55 100644
--- a/Websites/perf.webkit.org/ChangeLog
+++ b/Websites/perf.webkit.org/ChangeLog
@@ -1,3 +1,17 @@
+2018-07-13 Dewei Zhu <dewei_zhu@apple.com>
+
+ CustomConfigurationTestGroupForm should dispatch different arguments based on whether analysis task is created.
+ https://bugs.webkit.org/show_bug.cgi?id=187675
+
+ Reviewed by Ryosuke Niwa.
+
+ This change will fix the bug that no notification will be sent for any test groups except the
+ first one in any custom perf-try A/B task.
+
+ * public/v3/components/custom-configuration-test-group-form.js:
+ (CustomConfigurationTestGroupForm.prototype.startTesting): Conditionally includes taskName based on
+ whether or not analysis task is created.
+
2018-07-03 Dewei Zhu <dewei_zhu@apple.com>
MeasurementSet should merge last four segments into two if values are identical.
diff --git a/Websites/perf.webkit.org/public/v3/components/custom-configuration-test-group-form.js b/Websites/perf.webkit.org/public/v3/components/custom-configuration-test-group-form.js
index 2a2b867..bd94984 100644
--- a/Websites/perf.webkit.org/public/v3/components/custom-configuration-test-group-form.js
+++ b/Websites/perf.webkit.org/public/v3/components/custom-configuration-test-group-form.js
@@ -38,7 +38,11 @@
const commitSets = configurator.commitSets();
const platform = configurator.platform();
const test = configurator.tests()[0]; // FIXME: Add the support for specifying multiple tests.
- this.dispatchAction('startTesting', this._repetitionCount, testGroupName, commitSets, platform, test, taskName, this._notifyOnCompletion);
+ console.assert(!!this._hasTask === !taskName);
+ if (!this._hasTask)
+ this.dispatchAction('startTesting', this._repetitionCount, testGroupName, commitSets, platform, test, taskName, this._notifyOnCompletion);
+ else
+ this.dispatchAction('startTesting', this._repetitionCount, testGroupName, commitSets, platform, test, this._notifyOnCompletion);
}
didConstructShadowTree()
