tree 2cced0b9b1fd0347ed4722d23915a4412da8cb81
parent a75e32198b04cb683d515050e5f75c90e5f61b60
author mmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> 1571717119 +0000
committer mmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> 1571717119 +0000

[Cocoa] Move ui-serif, ui-monospaced, and ui-rounded out from behind SPI
https://bugs.webkit.org/show_bug.cgi?id=203129

Reviewed by Tim Horton.

Source/WebCore:

https://github.com/w3c/csswg-drafts/issues/4107 resolved to name these new fonts
ui-serif, ui-monospaced, and ui-rounded. This patch renames them, and removes the SPI
to access these fonts.

Tests: fast/text/design-system-ui*.html

* css/CSSFontFace.cpp:
(WebCore::CSSFontFace::shouldAllowDesignSystemUIFonts const): Deleted.
* css/CSSFontFace.h:
* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::load):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::initializeFontStyle):
* page/Settings.yaml:
* platform/graphics/FontCache.h:
(WebCore::FontDescriptionKey::makeFlagsKey):
* platform/graphics/FontDescription.cpp:
(WebCore::m_shouldAllowUserInstalledFonts):
(WebCore::m_shouldAllowDesignSystemUIFonts): Deleted.
* platform/graphics/FontDescription.h:
(WebCore::FontDescription::shouldAllowUserInstalledFonts const):
(WebCore::FontDescription::setShouldAllowUserInstalledFonts):
(WebCore::FontDescription::operator== const):
(WebCore::FontDescription::shouldAllowDesignSystemUIFonts const): Deleted.
(WebCore::FontDescription::setShouldAllowDesignSystemUIFonts): Deleted.
* platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::platformFontLookupWithFamily):
(WebCore::fontWithFamilySpecialCase):
* platform/graphics/cocoa/FontDescriptionCocoa.cpp:
(WebCore::matchSystemFontUse):
(WebCore::FontCascadeDescription::effectiveFamilyCount const):
(WebCore::FontCascadeDescription::effectiveFamilyAt const):
* platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:
(WebCore::SystemFontDatabaseCoreText::systemFontParameters):
* style/StyleResolveForDocument.cpp:
(WebCore::Style::resolveForDocument):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):

Source/WebKit:

* Shared/WebPreferences.yaml:
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _shouldAllowDesignSystemUIFonts]): Deleted.
(-[WKPreferences _setShouldAllowDesignSystemUIFonts:]): Deleted.
* UIProcess/API/Cocoa/WKPreferencesPrivate.h:

LayoutTests:

Update the tests to use the new names, and to not set the setting.

* fast/text/design-system-ui-10-expected-mismatch.html:
* fast/text/design-system-ui-10.html:
* fast/text/design-system-ui-11.html:
* fast/text/design-system-ui-12.html:
* fast/text/design-system-ui-13.html:
* fast/text/design-system-ui-14.html:
* fast/text/design-system-ui-15.html:
* fast/text/design-system-ui-16.html:
* fast/text/design-system-ui-2-expected.html:
* fast/text/design-system-ui-2.html:
* fast/text/design-system-ui-3-expected-mismatch.html:
* fast/text/design-system-ui-3.html:
* fast/text/design-system-ui-4-expected-mismatch.html:
* fast/text/design-system-ui-4.html:
* fast/text/design-system-ui-5-expected-mismatch.html:
* fast/text/design-system-ui-5.html:
* fast/text/design-system-ui-6-expected.html:
* fast/text/design-system-ui-6.html:
* fast/text/design-system-ui-7-expected.html:
* fast/text/design-system-ui-7.html:
* fast/text/design-system-ui-8-expected-mismatch.html:
* fast/text/design-system-ui-8.html:
* fast/text/design-system-ui-9-expected-mismatch.html:
* fast/text/design-system-ui-9.html:
* fast/text/design-system-ui-expected.html:
* fast/text/design-system-ui.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@251413 268f45cc-cd09-0410-ab3c-d52691b4dbfc