tree dd9a3fa9464775681c8ac12b68538b7f66117d41
parent 81d04bdc59ccc6be00b672782c15e7c29a031db9
author weinig@apple.com <weinig@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> 1600640780 +0000
committer weinig@apple.com <weinig@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> 1600640780 +0000

Using [Exposed=Window] with [Default] object toJSON() doesn't work
https://bugs.webkit.org/show_bug.cgi?id=216731

Reviewed by Simon Fraser.

Fixes filtering an attribute out of [Default] toJSON operation based
on which which global objects it is exposed to by ensuring we always
pass a global object pointer accessor function to
GenerateRuntimeEnableConditionalStringForExposed. For good measure,
we now always pass the global object object pointer to
GenerateRuntimeEnableConditionalString as well so that it is always
explicit.

This is needed to support filtering out Performance.navigation and
Performance.timing from the Performance interface's toJSON implementation
which will be addressed in a separate change.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateRuntimeEnableConditionalStringForExposed):
(GenerateRuntimeEnableConditionalString):
Remove implicit global object accessor string construction by always
requiring it to be passed.

* bindings/scripts/test/DOMWindowConstructors.idl:
* bindings/scripts/test/JS/JSDOMWindow.cpp:
* bindings/scripts/test/JS/JSTestDefaultToJSONFilteredByExposed.cpp: Added.
* bindings/scripts/test/JS/JSTestDefaultToJSONFilteredByExposed.h: Added.
* bindings/scripts/test/JS/JSWorkerGlobalScope.cpp:
* bindings/scripts/test/SupplementalDependencies.dep:
* bindings/scripts/test/TestDefaultToJSONFilteredByExposed.idl: Added.
* bindings/scripts/test/WorkerGlobalScopeConstructors.idl:
Add new test for updated behavior. I couldn't add it to the existing
TestDefaultToJSON.idl test as that test requires the interface only be exposed
to Window to support testing EnabledBySetting.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267331 268f45cc-cd09-0410-ab3c-d52691b4dbfc