commit | 4cef9c92cac34d28e8f94a82e7de63c05414ab54 | [log] [tgz] |
---|---|---|
author | dbates@webkit.org <dbates@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Thu May 09 17:41:20 2019 +0000 |
committer | dbates@webkit.org <dbates@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Thu May 09 17:41:20 2019 +0000 |
tree | 01cce99cc12ff93f6ca66490ea7e3fbaa60397c7 | |
parent | 90e4d904a364eb51e3d6f1e358f3aebbf5c76df7 [diff] |
[iOS] Unable to commit search on MSN.com, qq.com, or sina.com.cn using enter key (hardware or software keyboard) https://bugs.webkit.org/show_bug.cgi?id=197632 <rdar://problem/47902054> Reviewed by Brent Fulgham. Source/WebKit: Fixes an issue where it is not possible to submit a <form> with target = "_blank": a form that opens a new window. By default we only allow popups to open if they were user initiated (like when a person clicks on a link). We achieve this by putting a token on the stack, called the UserGestureToken when WebCore processes an event from WebKit. So long as this token is on the stack we consider all requests to open a popup to be user initiated. And we implicitly submit a form when pressing the Return key in an HTML input element during the processing of a TextInputEvent dispatched as part of inserting a '\n' into the field. On Mac, the keydown dispatches a TextInputEvent synchronously. However on iOS text insertion, and hence a dispatch of a TextInputEvent event, occurs asynchronously with respect to the keydown event. So, by the time the UI process calls back to the WebProcess to perform the text insertion of '\n' we have long since popped the UserGestureToken off the stack and hence we disallow opening a popup. To fix this, when -insertText is called we query the keyboard to determine if it's being called by the keyboard. If it is then we can assume that this is part of key event handling and hence was initiated by the user. We can pass along this detail to the WebProcess for it to push a new UserGestureToken onto the stack. For now we only track whether text inserted by the keyboard was user initiated or not. In <https://bugs.webkit.org/show_bug.cgi?id=197721> we will fix this up for all editing commands. * Platform/spi/ios/UIKitSPI.h: Expose SPI. * Shared/Cocoa/InsertTextOptions.cpp: (IPC::ArgumentCoder<WebKit::InsertTextOptions>::encode): (IPC::ArgumentCoder<WebKit::InsertTextOptions>::decode): Encode and decode whether we are processing a user gesture. * Shared/Cocoa/InsertTextOptions.h: * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView insertText:]): Query the keyboard to determine whether it called us or the embedding client did. We only want to privilege user initiated actions (the keyboard). * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::insertTextAsync): Push a UserGestureToken onto the stack that is initialized depending on whether we are or are not processing a user gesture. LayoutTests: Add tests to ensure we fire input and keypress events in the correct order and that we can submit a <form> with target = "_blank" using the Return key. * fast/events/ios/fire-input-and-keypress-on-return-key-expected.txt: Added. * fast/events/ios/fire-input-and-keypress-on-return-key.html: Added. * fast/events/ios/submit-form-target-blank-using-return-key-expected.txt: Added. * fast/events/ios/submit-form-target-blank-using-return-key.html: Added. * platform/ios/TestExpectations: Skip the test until we have the UIKit SPI added in <rdar://problem/50596032>. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@245144 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit is a cross-platform web browser engine. On iOS and macOS, it powers Safari, Mail, iBooks, and many other applications.
Visit WebKit Feature Status page to see which Web API has been implemented, in development, or under consideration.
On macOS, download Safari Technology Preview to test the latest version of WebKit. On Linux, download Epiphany Technology Preview. On Windows, you'll have to build it yourself.
Once your bug is filed, you will receive email when it is updated at each stage in the bug life cycle. After the bug is considered fixed, you may be asked to download the latest nightly and confirm that the fix works for you.
On Windows, follow the instructions on our website.
Run the following command to clone WebKit's Git SVN repository:
git clone git://git.webkit.org/WebKit.git WebKit
or
git clone https://git.webkit.org/git/WebKit.git WebKit
If you want to be able to commit changes to the repository, or just want to check out branches that aren’t contained in WebKit.git, you will need track WebKit's Subversion repository. You can run the following command to configure this and other options of the new Git clone for WebKit development.
Tools/Scripts/webkit-patch setup-git-clone
For information about this, and other aspects of using Git with WebKit, read the wiki page.
If you don‘t want to use Git, run the following command to check out WebKit’s Subversion repository:
svn checkout https://svn.webkit.org/repository/webkit/trunk WebKit
Install Xcode and its command line tools if you haven't done so already:
xcode-select --install
Run the following command to build a debug build with debugging symbols and assertions:
Tools/Scripts/build-webkit --debug
For performance testing, and other purposes, use --release
instead.
You can open WebKit.xcworkspace
to build and debug WebKit within Xcode.
If you don't use a custom build location in Xcode preferences, you have to update the workspace settings to use WebKitBuild
directory. In menu bar, choose File > Workspace Settings, then click the Advanced button, select “Custom”, “Relative to Workspace”, and enter WebKitBuild
for both Products and Intermediates.
The first time after you install a new Xcode, you will need to run the following command to enable Xcode to build command line tools for iOS Simulator:
sudo Tools/Scripts/configure-xcode-for-ios-development
Without this step, you will see the error message: “target specifies product type ‘com.apple.product-type.tool’, but there’s no such product type for the ‘iphonesimulator’ platform.
” when building target JSCLLIntOffsetsExtractor
of project JavaScriptCore
.
Run the following command to build a debug build with debugging symbols and assertions for iOS:
Tools/Scripts/build-webkit --debug --ios-simulator
For production builds:
cmake -DPORT=GTK -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/gtk/install-dependencies Tools/Scripts/update-webkitgtk-libs Tools/Scripts/build-webkit --gtk --debug
For more information on building WebKitGTK+, see the wiki page.
For production builds:
cmake -DPORT=WPE -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/wpe/install-dependencies Tools/Scripts/update-webkitwpe-libs Tools/Scripts/build-webkit --wpe --debug
For building WebKit on Windows, see the wiki page.
Run the following command to launch Safari with your local build of WebKit:
Tools/Scripts/run-safari --debug
The run-safari
script sets the DYLD_FRAMEWORK_PATH
environment variable to point to your build products, and then launches /Applications/Safari.app
. DYLD_FRAMEWORK_PATH
tells the system loader to prefer your build products over the frameworks installed in /System/Library/Frameworks
.
To run other applications with your local build of WebKit, run the following command:
Tools/Scripts/run-webkit-app <application-path>
Run the following command to launch iOS simulator with your local build of WebKit:
run-safari --debug --ios-simulator
In both cases, if you have built release builds instead, use --release
instead of --debug
.
If you have a development build, you can use the run-minibrowser script, e.g.:
run-minibrowser --debug --wpe
Pass one of --gtk
, --jsc-only
, or --wpe
to indicate the port to use.
Congratulations! You’re up and running. Now you can begin coding in WebKit and contribute your fixes and new features to the project. For details on submitting your code to the project, read Contributing Code.