commit | 5f149ec359e42103ef84148247c17c244c452e22 | [log] [tgz] |
---|---|---|
author | wenson_hsieh@apple.com <wenson_hsieh@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Thu Oct 10 01:27:14 2019 +0000 |
committer | wenson_hsieh@apple.com <wenson_hsieh@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Thu Oct 10 01:27:14 2019 +0000 |
tree | db942d8a4964ce0e3692f370f77f89c852495827 | |
parent | 422f532713c03a73dbd6416acb79b3b4f3a9d585 [diff] |
[Clipboard API] Refactor Pasteboard item reading functions to work on both iOS and macOS https://bugs.webkit.org/show_bug.cgi?id=202647 Reviewed by Tim Horton. Source/WebCore: Moves some pasteboard helper functions out of iOS-specific code, and into platform-agnostic code. See below for more details. There is no change in behavior, as nothing exercises these new pasteboard functions on macOS yet. * SourcesCocoa.txt: * WebCore.xcodeproj/project.pbxproj: * platform/Pasteboard.cpp: (WebCore::Pasteboard::allPasteboardItemInfo const): (WebCore::Pasteboard::pasteboardItemInfo const): (WebCore::Pasteboard::readString): (WebCore::Pasteboard::readBuffer): (WebCore::Pasteboard::readURL): Add some new helpers on Pasteboard to read Strings, data, and URLs from the platform pasteboard. These forward to the platform strategy which, in WebKit2, are currently implemented using sync IPC, but could be changed in the future to be fully asynchronous. * platform/Pasteboard.h: (WebCore::Pasteboard::name const): Expose a cross-platform name() getter on Pasteboard. On non-Cocoa platforms, this simply returns the empty string, but on macOS and iOS, this returns the platform pasteboard name, which is stored in m_pasteboardName. * platform/PasteboardItemInfo.h: (WebCore::PasteboardItemInfo::pathForContentType const): (WebCore::PasteboardItemInfo::contentTypeForHighestFidelityItem const): (WebCore::PasteboardItemInfo::encode const): (WebCore::PasteboardItemInfo::decode): Adds a couple of new members to PasteboardItemInfo (which represents metadata about a given item in the platform pasteboard). These are changeCount (which is self explanatory), and webSafeTypesByFidelity, which is a list of types in fidelity order which contains the list of pasteboard types that are safe to expose to bindings. These may include types such as "text/plain", "text/html", "text/uri-list", and "image/png". To distinguish this list from the existing contentTypesByFidelity list, I've also renamed contentTypesByFidelity to platformTypesByFidelity, to make it more obvious that this other list of types are platform-specific, and not generally safe to expose to the web. * platform/PasteboardStrategy.h: * platform/PlatformPasteboard.h: Move several helpers out into platform-agnostic code. * platform/cocoa/PasteboardCocoa.mm: (WebCore::Pasteboard::fileContentState): * platform/cocoa/PlatformPasteboardCocoa.mm: Added. Add a new file to contain the implementation of PlatformPasteboard::allPasteboardItemInfo, which is the same across Cocoa platforms. (WebCore::PlatformPasteboard::allPasteboardItemInfo): * platform/ios/PasteboardIOS.mm: (WebCore::Pasteboard::readRespectingUTIFidelities): * platform/ios/PlatformPasteboardIOS.mm: (WebCore::PlatformPasteboard::informationForItemAtIndex): (WebCore::PlatformPasteboard::readBuffer const): (WebCore::PlatformPasteboard::readString const): (WebCore::PlatformPasteboard::readURL const): Additionally refactor all methods on PlatformPasteboard that take pasteboard item indices as signed integers (`int`) to receive `size_t` values instead. (WebCore::PlatformPasteboard::allPasteboardItemInfo): Deleted. * platform/libwpe/PasteboardLibWPE.cpp: (WebCore::Pasteboard::readString): (WebCore::Pasteboard::read): * platform/libwpe/PlatformPasteboardLibWPE.cpp: (WebCore::PlatformPasteboard::readString const): Add an implementation stub for WPE. * platform/mac/PlatformPasteboardMac.mm: (WebCore::modernPasteboardTypeForWebSafeMIMEType): (WebCore::webSafeMIMETypeForModernPasteboardType): Add helpers to convert between modern NSPasteboardTypes and web-safe types. While some logic exists today on macOS to convert between legacy pasteboard types and web-safe types, conversion between the modern pasteboard types and web-safe types are needed since NSPasteboardItem's types only support NSPasteboardTypes and dynamically declared types that match the format of a universal type identfier (for instance, "com.foo.bar"). (WebCore::PlatformPasteboard::readBuffer const): (WebCore::PlatformPasteboard::readString const): (WebCore::PlatformPasteboard::readURL const): (WebCore::PlatformPasteboard::count const): (WebCore::PlatformPasteboard::informationForItemAtIndex): Implement all of these helpers by looking up the NSPasteboardItem at the given item index and querying it for data for non-legacy pasteboard types. (WebCore::PlatformPasteboard::itemAtIndex const): Source/WebKit: Refactor iOS-specific pasteboard functions to be platform-agnostic. See WebCore ChangeLog for more details. * UIProcess/Cocoa/WebPasteboardProxyCocoa.mm: (WebKit::WebPasteboardProxy::allPasteboardItemInfo): (WebKit::WebPasteboardProxy::informationForItemAtIndex): (WebKit::WebPasteboardProxy::getPasteboardItemsCount): (WebKit::WebPasteboardProxy::readStringFromPasteboard): (WebKit::WebPasteboardProxy::readURLFromPasteboard): (WebKit::WebPasteboardProxy::readBufferFromPasteboard): (WebKit::WebPasteboardProxy::writeURLToPasteboard): (WebKit::WebPasteboardProxy::writeWebContentToPasteboard): (WebKit::WebPasteboardProxy::writeImageToPasteboard): (WebKit::WebPasteboardProxy::writeStringToPasteboard): * UIProcess/WebPasteboardProxy.cpp: (WebKit::WebPasteboardProxy::allPasteboardItemInfo): (WebKit::WebPasteboardProxy::informationForItemAtIndex): (WebKit::WebPasteboardProxy::getPasteboardItemsCount): (WebKit::WebPasteboardProxy::readStringFromPasteboard): (WebKit::WebPasteboardProxy::readURLFromPasteboard): (WebKit::WebPasteboardProxy::readBufferFromPasteboard): * UIProcess/WebPasteboardProxy.h: * UIProcess/WebPasteboardProxy.messages.in: * UIProcess/wpe/WebPasteboardProxyWPE.cpp: * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::informationForItemAtIndex): (WebKit::WebPlatformStrategies::readBufferFromPasteboard): (WebKit::WebPlatformStrategies::readURLFromPasteboard): (WebKit::WebPlatformStrategies::readStringFromPasteboard): (WebKit::WebPlatformStrategies::writeToPasteboard): (WebKit::WebPlatformStrategies::updateSupportedTypeIdentifiers): * WebProcess/WebCoreSupport/WebPlatformStrategies.h: Source/WebKitLegacy/mac: Refactor iOS-specific pasteboard functions to be platform-agnostic. See WebCore ChangeLog for more details. * WebCoreSupport/WebPlatformStrategies.h: * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::informationForItemAtIndex): (WebPlatformStrategies::allPasteboardItemInfo): (WebPlatformStrategies::getPasteboardItemsCount): (WebPlatformStrategies::readBufferFromPasteboard): (WebPlatformStrategies::readURLFromPasteboard): (WebPlatformStrategies::readStringFromPasteboard): (WebPlatformStrategies::writeToPasteboard): (WebPlatformStrategies::updateSupportedTypeIdentifiers): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@250950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit is a cross-platform web browser engine. On iOS and macOS, it powers Safari, Mail, iBooks, and many other applications.
Visit WebKit Feature Status page to see which Web API has been implemented, in development, or under consideration.
On macOS, download Safari Technology Preview to test the latest version of WebKit. On Linux, download Epiphany Technology Preview. On Windows, you'll have to build it yourself.
Once your bug is filed, you will receive email when it is updated at each stage in the bug life cycle. After the bug is considered fixed, you may be asked to download the latest nightly and confirm that the fix works for you.
On Windows, follow the instructions on our website.
Run the following command to clone WebKit's Git SVN repository:
git clone git://git.webkit.org/WebKit.git WebKit
or
git clone https://git.webkit.org/git/WebKit.git WebKit
If you want to be able to commit changes to the repository, or just want to check out branches that aren’t contained in WebKit.git, you will need track WebKit's Subversion repository. You can run the following command to configure this and other options of the new Git clone for WebKit development.
Tools/Scripts/webkit-patch setup-git-clone
For information about this, and other aspects of using Git with WebKit, read the wiki page.
If you don‘t want to use Git, run the following command to check out WebKit’s Subversion repository:
svn checkout https://svn.webkit.org/repository/webkit/trunk WebKit
Install Xcode and its command line tools if you haven't done so already:
xcode-select --install
Run the following command to build a debug build with debugging symbols and assertions:
Tools/Scripts/build-webkit --debug
For performance testing, and other purposes, use --release
instead.
You can open WebKit.xcworkspace
to build and debug WebKit within Xcode.
If you don't use a custom build location in Xcode preferences, you have to update the workspace settings to use WebKitBuild
directory. In menu bar, choose File > Workspace Settings, then click the Advanced button, select “Custom”, “Relative to Workspace”, and enter WebKitBuild
for both Products and Intermediates.
The first time after you install a new Xcode, you will need to run the following command to enable Xcode to build command line tools for iOS Simulator:
sudo Tools/Scripts/configure-xcode-for-ios-development
Without this step, you will see the error message: “target specifies product type ‘com.apple.product-type.tool’, but there’s no such product type for the ‘iphonesimulator’ platform.
” when building target JSCLLIntOffsetsExtractor
of project JavaScriptCore
.
Run the following command to build a debug build with debugging symbols and assertions for iOS:
Tools/Scripts/build-webkit --debug --ios-simulator
For production builds:
cmake -DPORT=GTK -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/gtk/install-dependencies Tools/Scripts/update-webkitgtk-libs Tools/Scripts/build-webkit --gtk --debug
For more information on building WebKitGTK+, see the wiki page.
For production builds:
cmake -DPORT=WPE -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/wpe/install-dependencies Tools/Scripts/update-webkitwpe-libs Tools/Scripts/build-webkit --wpe --debug
For building WebKit on Windows, see the wiki page.
Run the following command to launch Safari with your local build of WebKit:
Tools/Scripts/run-safari --debug
The run-safari
script sets the DYLD_FRAMEWORK_PATH
environment variable to point to your build products, and then launches /Applications/Safari.app
. DYLD_FRAMEWORK_PATH
tells the system loader to prefer your build products over the frameworks installed in /System/Library/Frameworks
.
To run other applications with your local build of WebKit, run the following command:
Tools/Scripts/run-webkit-app <application-path>
Run the following command to launch iOS simulator with your local build of WebKit:
run-safari --debug --ios-simulator
In both cases, if you have built release builds instead, use --release
instead of --debug
.
If you have a development build, you can use the run-minibrowser script, e.g.:
run-minibrowser --debug --wpe
Pass one of --gtk
, --jsc-only
, or --wpe
to indicate the port to use.
Congratulations! You’re up and running. Now you can begin coding in WebKit and contribute your fixes and new features to the project. For details on submitting your code to the project, read Contributing Code.