commit 2164895bc0b1695d939f61d07b5b88b2c6d665f7
author caitp@igalia.com <caitp@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Thu Jun 25 02:05:51 2020 +0000
committer caitp@igalia.com <caitp@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Thu Jun 25 02:05:51 2020 +0000
tree 506271ba8fb792862f587498998de9c0d7c96f43
parent 16a7748f85f9bc9fafa9c9792704de604ed78f0b

[JSC] handle Put/DefinePrivateField in resetPutByID
https://bugs.webkit.org/show_bug.cgi?id=213583

Reviewed by Yusuke Suzuki.

r262613 extends and uses PutByValDirect to support updating and defining private fields, in order to reuse
the IC machinery. The necessary resetPutByID change was erroneously omitted, and is presented here.

* jit/Repatch.cpp:
(JSC::resetPutByID):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@263491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/JavaScriptCore/ChangeLog

diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
index 184d6a3..41bdeab 100644
--- a/Source/JavaScriptCore/ChangeLog
+++ b/Source/JavaScriptCore/ChangeLog
@@ -1,3 +1,16 @@
+2020-06-24  Caitlin Potter  <caitp@igalia.com>
+
+        [JSC] handle Put/DefinePrivateField in resetPutByID
+        https://bugs.webkit.org/show_bug.cgi?id=213583
+
+        Reviewed by Yusuke Suzuki.
+
+        r262613 extends and uses PutByValDirect to support updating and defining private fields, in order to reuse
+        the IC machinery. The necessary resetPutByID change was erroneously omitted, and is presented here.
+
+        * jit/Repatch.cpp:
+        (JSC::resetPutByID):
+
 2020-06-24  Yusuke Suzuki  <ysuzuki@apple.com>
 
         [JSC] llintTrue / jitTrue can encounter native functions

Source/JavaScriptCore/jit/Repatch.cpp

diff --git a/Source/JavaScriptCore/jit/Repatch.cpp b/Source/JavaScriptCore/jit/Repatch.cpp
index ca5b894..258f139 100644
--- a/Source/JavaScriptCore/jit/Repatch.cpp
+++ b/Source/JavaScriptCore/jit/Repatch.cpp
@@ -1483,6 +1483,10 @@
         optimizedFunction = operationPutByIdNonStrictOptimize;
     else if (unoptimizedFunction == operationPutByIdDirectStrict || unoptimizedFunction == operationPutByIdDirectStrictOptimize)
         optimizedFunction = operationPutByIdDirectStrictOptimize;
+    else if (unoptimizedFunction == operationPutByIdPutPrivateFieldStrict || unoptimizedFunction == operationPutByIdPutPrivateFieldStrictOptimize)
+        optimizedFunction = operationPutByIdPutPrivateFieldStrictOptimize;
+    else if (unoptimizedFunction == operationPutByIdDefinePrivateFieldStrict || unoptimizedFunction == operationPutByIdDefinePrivateFieldStrictOptimize)
+        optimizedFunction = operationPutByIdDefinePrivateFieldStrictOptimize;
     else {
         ASSERT(unoptimizedFunction == operationPutByIdDirectNonStrict || unoptimizedFunction == operationPutByIdDirectNonStrictOptimize);
         optimizedFunction = operationPutByIdDirectNonStrictOptimize;