commit | 1d17a8f7ca49d9a351cbca5116780cdd63909d69 | [log] [tgz] |
---|---|---|
author | darin@apple.com <darin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Sun Oct 08 22:17:46 2017 +0000 |
committer | darin@apple.com <darin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Sun Oct 08 22:17:46 2017 +0000 |
tree | 3e57eacc789ecdd6d6ccb0eab1835a0aeb70b8c1 | |
parent | da5e54a02bcfdd7d5316373ae09da8cdec3628fd [diff] |
Fix bugs related to setting reflected floating point DOM attributes https://bugs.webkit.org/show_bug.cgi?id=178061 Reviewed by Sam Weinig. LayoutTests/imported/w3c: * web-platform-tests/html/dom/reflection-forms-expected.txt: Updated to expect meter reflection tests to pass. Source/WebCore: * html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::setValue): Changed the semantics to match what the HTML specification calls for. When a caller passes a negative number or zero, the value does get set on the element. Negative numbers are not allowed when you get the current value, but are allowed to be set. (WebCore::HTMLProgressElement::setMax): Changed the semantics to match what the HTML specification calls for. When a caller passes a negative number or zero, this should leave the attribute unchanged. * html/shadow/MediaControlElementTypes.cpp: (WebCore::MediaControlVolumeSliderElement::setVolume): Use String::numberToStringECMAScript instead of String::number since that is what we want any time we are setting an attribute value from a floating point value. * html/shadow/MediaControlElements.cpp: (WebCore::MediaControlTimelineElement::setPosition): Ditto. (WebCore::MediaControlTimelineElement::setDuration): Removed unneeded check of std::isfinite since the single caller already checks that. Source/WTF: * wtf/dtoa.cpp: (WTF::formatStringTruncatingTrailingZerosIfNeeded): Fix a bug where this function would remove trailing zeroes from the exponent if present instead of from the mantissa. This meant that it would format 1e10 as "1.00000e+1" instead of "1e+10". Added regression tests for this to TestWebKitAPI. * wtf/dtoa/utils.h: (WTF::double_conversion::StringBuilder::RemoveCharacters): Added. Used by the fix above. * wtf/text/AtomicString.cpp: (WTF::AtomicString::number): Note: This function is used by code that sets the values of reflected floating point DOM attributes. Changed the function to use the rules from numberToString rather ones from numberToFixedPrecisionString. This is analogous to String::numberToStringECMAScript, and in the future we should change String and StringBuilder so this "ECMAScript" semantic is the default way to convert a floating point number to a string, and rename the fixed precision version that is currently called String::number. I audited the small number of sites calling AtomicString::number, by temporarily renaming it, and discovered that this is the correct behavior for all; none needed fixed precision. Also, fixed a mistake where this explicitly converted to String. That was defeating the purpose of having these functions in AtomicString: It would allocate a new String and then destroy it in the case where an equal string was already in the AtomicString table. Tools: * TestWebKitAPI/Tests/WTF/AtomicString.cpp: Added a test of the AtomicString::number function, based on the test cases we already had for String::numberToStringECMAScript, and with some additional cases with powers of 10 that check handling of trailng zeroes. * TestWebKitAPI/Tests/WTF/WTFString.cpp: Added test cases to the existing tests of the String::numberToStringECMAScript function as above. Also added tests for String::number and for String::numberToStringFixedWidth. Also changed the tests to all use EXPECT instead of ASSERT macros since these are all non-fatal. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::dumpFrameScrollPosition): Use StringBuilder::appendECMAScriptNumber instead of String::number. LayoutTests: * fast/dom/HTMLProgressElement/set-progress-properties-expected.txt: Updated test to expect setting HTMLProgressElement.max to 0 to have no effect, rather than setting max to "1". * fast/dom/HTMLProgressElement/set-progress-properties.html: Ditto. * platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt: Updated to expect meter reflection tests to pass. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@223035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit is a cross-platform web browser engine. On iOS and macOS, it powers Safari, Mail, iBooks, and many other applications.
Visit WebKit Feature Status page to see which Web API has been implemented, in development, or under consideration.
Downloading Safari Technology Preview to test the latest version of WebKit.
Once your bug is filed, you will receive email when it is updated at each stage in the bug life cycle. After the bug is considered fixed, you may be asked to download the latest nightly and confirm that the fix works for you.
On Windows, follow the instructions on our website.
Run the following command to clone WebKit's Git SVN repository:
git clone git://git.webkit.org/WebKit.git WebKit
If you want to be able to commit changes to the repository, or just want to check out branches that aren’t contained in WebKit.git, you will need track WebKit's Subversion repository. You can run the following command to configure this and other options of the new Git clone for WebKit development.
Tools/Scripts/webkit-patch setup-git-clone
For information about this, and other aspects of using Git with WebKit, read the wiki page.
Run the following command to check out WebKit's subversion repository:
svn checkout https://svn.webkit.org/repository/webkit/trunk WebKit
Install Xcode and its command line tools if you haven't done so already:
xcode-select --install
Run the following command to build a debug build with debugging symbols and assertions:
Tools/Scripts/build-webkit --debug
For performance testing, and other purposes, use --release
instead.
You can open WebKit.xcworkspace
to build and debug WebKit within WebKit.
If you don't use a custom build location in Xcode preferences, you have to update the workspace settings to use WebKitBuild
directory. In menu bar, choose File > Workspace Settings, then click the Advanced button, select “Custom”, “Relative to Workspace”, and enter WebKitBuild
for both Products and Intermediates.
The first time after you install a new Xcode, you will need to run the following command to enable Xcode to build command line tools for iOS Simulator:
sudo Tools/Scripts/configure-xcode-for-ios-development
Without this step, you will see the error message: “target specifies product type ‘com.apple.product-type.tool’, but there’s no such product type for the ‘iphonesimulator’ platform.
” when building target JSCLLIntOffsetsExtractor
of project JavaScriptCore
.
Run the following command to build a debug build with debugging symbols and assertions for iOS:
Tools/Scripts/build-webkit --debug --ios-simulator.
Install the dependencies by running the following command:
Tools/gtk/install-dependencies
Then run the following command to build additional dependencies:
Tools/Scripts/update-webkitgtk-libs
Run the following command to build WebKit with debugging symbols for GTK+ port:
Tools/Scripts/build-webkit --debug --gtk
Note that the procedure for building a release tarball is different. For more information, see the wiki page.
For building WebKit on Windows, see the wiki page.
Run the following command to launch Safari with your local build of WebKit:
Tools/Scripts/run-safari --debug
The run-safari
script sets the DYLD_FRAMEWORK_PATH
environment variable to point to your build products, and then launches /Applications/Safari.app
. DYLD_FRAMEWORK_PATH
tells the system loader to prefer your build products over the frameworks installed in /System/Library/Frameworks
.
To run other applications with your local build of WebKit, run the following command:
Tools/Scripts/run-webkit-app <application-path>
Run the following command to launch iOS simulator with your local build of WebKit:
run-safari --debug --ios-simulator
In both cases, if you have built release builds instead, use --release
instead of --debug
.
Congratulations! You’re up and running. Now you can begin coding in WebKit and contribute your fixes and new features to the project. For details on submitting your code to the project, read Contributing Code.