commit 14789b9f5ec3fbeb99719fb397e7681417ac0049
author kling@webkit.org <kling@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Thu Feb 23 21:15:16 2012 +0000
committer kling@webkit.org <kling@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Thu Feb 23 21:15:16 2012 +0000
tree 3a7dca52699380bc236cc6eedf9a627cbfb6b82f
parent da03b99d4cd843e7b48a6a6478743b9a03ea055a

Make use of StylePropertySet::setProperty(propertyID, CSSValue).
<http://webkit.org/b/79374>

Reviewed by Antti Koivisto.

Use the new setProperty() overload that takes a CSSValue in more places. This allows us
to get rid of 1/3 setProperty() overloads that don't expand shorthands.

* css/StylePropertySet.h:
* css/StylePropertySet.cpp:

    Remove the setProperty() overload for specific primitive value types. StyledElement
    can take care of this without help from StylePropertySet.

* dom/StyledElement.h:
* dom/StyledElement.cpp:
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::addPropertyToAttributeStyle):

    Switch some functions over to using the setProperty() overload that takes a CSSValue.

* html/HTMLElement.cpp:
(WebCore::HTMLElement::applyBorderAttributeToStyle):
* html/HTMLHRElement.cpp:
(WebCore::HTMLHRElement::collectStyleForAttribute):
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::collectStyleForAttribute):
* html/HTMLTablePartElement.cpp:
(WebCore::HTMLTablePartElement::collectStyleForAttribute):

    Use shorthands where possible to shrink the code a bit. Pass border widths as CSS_PX
    values directly instead of making a CSSParser round-trip.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/html/HTMLTableElement.cpp

diff --git a/Source/WebCore/html/HTMLTableElement.cpp b/Source/WebCore/html/HTMLTableElement.cpp
index 4f65062..1d2c80a 100644
--- a/Source/WebCore/html/HTMLTableElement.cpp
+++ b/Source/WebCore/html/HTMLTableElement.cpp
@@ -341,10 +341,7 @@
         bool borderBottom;
         bool borderLeft;
         if (getBordersFromFrameAttributeValue(attr->value(), borderTop, borderRight, borderBottom, borderLeft)) {
-            addPropertyToAttributeStyle(style, CSSPropertyBorderTopWidth, CSSValueThin);
-            addPropertyToAttributeStyle(style, CSSPropertyBorderBottomWidth, CSSValueThin);
-            addPropertyToAttributeStyle(style, CSSPropertyBorderLeftWidth, CSSValueThin);
-            addPropertyToAttributeStyle(style, CSSPropertyBorderRightWidth, CSSValueThin);
+            addPropertyToAttributeStyle(style, CSSPropertyBorderWidth, CSSValueThin);
             addPropertyToAttributeStyle(style, CSSPropertyBorderTopStyle, borderTop ? CSSValueSolid : CSSValueHidden);
             addPropertyToAttributeStyle(style, CSSPropertyBorderBottomStyle, borderBottom ? CSSValueSolid : CSSValueHidden);
             addPropertyToAttributeStyle(style, CSSPropertyBorderLeftStyle, borderLeft ? CSSValueSolid : CSSValueHidden);