commit | 12d2fe76b1ed5815de1fb2b7df4bb17b6b7c9ee7 | [log] [tgz] |
---|---|---|
author | achristensen@apple.com <achristensen@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Tue Oct 22 01:34:39 2019 +0000 |
committer | achristensen@apple.com <achristensen@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | Tue Oct 22 01:34:39 2019 +0000 |
tree | fcd0f129e86d118cdff88203f9eec535db352b84 | |
parent | 9cd9e7986fa2c14e096f6c84c9dfa03c736cff48 [diff] |
Move service worker registration matching for navigation loads to network process https://bugs.webkit.org/show_bug.cgi?id=203144 Patch by youenn fablet <youenn@apple.com> on 2019-10-21 Reviewed by Chris Dumez. Source/WebCore: For regular loads, we no longer match service worker registration explicitly. This is now done by NetworkResourceLoader explicitly. We still need to explicitely match registrations in those two cases: - There is an app cache resource that can be used. We will use it only if there is no registration. - There is a resource from the meory cache that can be used. We will match the registration to make sure the document is controlled by the right service worker. The load will still be served from the memory cache. Since DocumentLoader is no longer matching registration, we need a way from NetworkProcess to inform that there is a matching registration and that the document is controlled. For that purpose, DocumentLoader is adding itself in a global map with the temporary document identifier as the key. Adding to the map happens when loading the main resource and removal from the map happens when destroying the DocumentLoader. For this to happen properly, the temporary document identifier is kept the same for the lifetime of the DocumentLoader. Registration matching was postponed until service worker registration is done. Since we no longer do registration matching in WebProcess, we need to wait in NetworkProcess for that to happen. We introduce a way for SWServer to notify when import is completed for that purpose. Covered by existing tests. * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::fromTemporaryDocumentIdentifier): (WebCore::DocumentLoader::~DocumentLoader): (WebCore::DocumentLoader::setControllingServiceWorkerRegistration): (WebCore::DocumentLoader::redirectReceived): (WebCore::DocumentLoader::responseReceived): (WebCore::DocumentLoader::startLoadingMainResource): (WebCore::DocumentLoader::unregisterTemporaryServiceWorkerClient): (WebCore::DocumentLoader::loadMainResource): * loader/DocumentLoader.h: * loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::canLoadMainResource): * loader/appcache/ApplicationCacheHost.h: * workers/service/server/SWServer.cpp: (WebCore::SWServer::~SWServer): (WebCore::SWServer::registrationStoreImportComplete): (WebCore::SWServer::whenImportIsCompleted): (WebCore::SWServer::doRegistrationMatching): * workers/service/server/SWServer.h: (WebCore::SWServer::isImportCompleted const): Source/WebKit: Create a WebSWServerConnection whenever receiving a load request in NetworkProcess. This connection is used to check for service worker registration in case of navigation loads. Similarly, we create a WebSWClientConnection whenever WebProcess needs it, including when receiving WebSWClientConnection messages from NetworkProcess. This for instance happens when service worker registration import is complete to fill the shared registration origin store. Delay loads until SWServer has finished importing its registrations. This is needed since we might otherwise not intercept loads that could be intercepted. Waiting for importing registrations was previously ensured by WebProcess getting a matching registration in DocumentLoader. NetworkResourceLoader is now checking for service worker interception in case of redirections for navigations. This is needed as redirections could end up using a new registration. * NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::NetworkConnectionToWebProcess): (WebKit::NetworkConnectionToWebProcess::scheduleResourceLoad): (WebKit::NetworkConnectionToWebProcess::establishSWServerConnection): (WebKit::NetworkConnectionToWebProcess::swConnection): * NetworkProcess/NetworkConnectionToWebProcess.h: * NetworkProcess/NetworkConnectionToWebProcess.messages.in: * NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::continueWillSendRequest): (WebKit::NetworkResourceLoader::startWithServiceWorker): (WebKit::NetworkResourceLoader::serviceWorkerDidNotHandle): * NetworkProcess/NetworkResourceLoader.h: * NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp: (WebKit::ServiceWorkerFetchTask::ServiceWorkerFetchTask): (WebKit::ServiceWorkerFetchTask::start): (WebKit::ServiceWorkerFetchTask::startFetch): (WebKit::ServiceWorkerFetchTask::continueFetchTaskWith): * NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.h: (WebKit::ServiceWorkerFetchTask::takeRequest): * NetworkProcess/ServiceWorker/WebSWServerConnection.cpp: (WebKit::WebSWServerConnection::controlClient): (WebKit::WebSWServerConnection::createFetchTask): * NetworkProcess/ServiceWorker/WebSWServerConnection.h: * WebProcess/Network/NetworkProcessConnection.cpp: (WebKit::NetworkProcessConnection::didReceiveMessage): * WebProcess/Network/WebLoaderStrategy.cpp: (WebKit::WebLoaderStrategy::scheduleLoad): * WebProcess/Storage/WebSWClientConnection.cpp: (WebKit::WebSWClientConnection::WebSWClientConnection): (WebKit::WebSWClientConnection::registrationReady): (WebKit::WebSWClientConnection::documentIsControlled): * WebProcess/Storage/WebSWClientConnection.h: * WebProcess/Storage/WebSWClientConnection.messages.in: Tools: * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm: We are now creating a WebSWClientConnection whenever receiving a WebSWClientConnection message from NetworkProcess. It is free to do so given it no longer requires sending some IPC. Update the tests accordingly. A future patch will remove the service worker registration bit feature and corresponding test. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@251409 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit is a cross-platform web browser engine. On iOS and macOS, it powers Safari, Mail, iBooks, and many other applications.
Visit WebKit Feature Status page to see which Web API has been implemented, in development, or under consideration.
On macOS, download Safari Technology Preview to test the latest version of WebKit. On Linux, download Epiphany Technology Preview. On Windows, you'll have to build it yourself.
Once your bug is filed, you will receive email when it is updated at each stage in the bug life cycle. After the bug is considered fixed, you may be asked to download the latest nightly and confirm that the fix works for you.
On Windows, follow the instructions on our website.
Run the following command to clone WebKit's Git SVN repository:
git clone git://git.webkit.org/WebKit.git WebKit
or
git clone https://git.webkit.org/git/WebKit.git WebKit
If you want to be able to commit changes to the repository, or just want to check out branches that aren’t contained in WebKit.git, you will need track WebKit's Subversion repository. You can run the following command to configure this and other options of the new Git clone for WebKit development.
Tools/Scripts/webkit-patch setup-git-clone
For information about this, and other aspects of using Git with WebKit, read the wiki page.
If you don‘t want to use Git, run the following command to check out WebKit’s Subversion repository:
svn checkout https://svn.webkit.org/repository/webkit/trunk WebKit
Install Xcode and its command line tools if you haven't done so already:
xcode-select --install
Run the following command to build a debug build with debugging symbols and assertions:
Tools/Scripts/build-webkit --debug
For performance testing, and other purposes, use --release
instead.
You can open WebKit.xcworkspace
to build and debug WebKit within Xcode.
If you don't use a custom build location in Xcode preferences, you have to update the workspace settings to use WebKitBuild
directory. In menu bar, choose File > Workspace Settings, then click the Advanced button, select “Custom”, “Relative to Workspace”, and enter WebKitBuild
for both Products and Intermediates.
The first time after you install a new Xcode, you will need to run the following command to enable Xcode to build command line tools for iOS Simulator:
sudo Tools/Scripts/configure-xcode-for-ios-development
Without this step, you will see the error message: “target specifies product type ‘com.apple.product-type.tool’, but there’s no such product type for the ‘iphonesimulator’ platform.
” when building target JSCLLIntOffsetsExtractor
of project JavaScriptCore
.
Run the following command to build a debug build with debugging symbols and assertions for iOS:
Tools/Scripts/build-webkit --debug --ios-simulator
For production builds:
cmake -DPORT=GTK -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/gtk/install-dependencies Tools/Scripts/update-webkitgtk-libs Tools/Scripts/build-webkit --gtk --debug
For more information on building WebKitGTK+, see the wiki page.
For production builds:
cmake -DPORT=WPE -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja ninja sudo ninja install
For development builds:
Tools/wpe/install-dependencies Tools/Scripts/update-webkitwpe-libs Tools/Scripts/build-webkit --wpe --debug
For building WebKit on Windows, see the wiki page.
Run the following command to launch Safari with your local build of WebKit:
Tools/Scripts/run-safari --debug
The run-safari
script sets the DYLD_FRAMEWORK_PATH
environment variable to point to your build products, and then launches /Applications/Safari.app
. DYLD_FRAMEWORK_PATH
tells the system loader to prefer your build products over the frameworks installed in /System/Library/Frameworks
.
To run other applications with your local build of WebKit, run the following command:
Tools/Scripts/run-webkit-app <application-path>
Run the following command to launch iOS simulator with your local build of WebKit:
run-safari --debug --ios-simulator
In both cases, if you have built release builds instead, use --release
instead of --debug
.
If you have a development build, you can use the run-minibrowser script, e.g.:
run-minibrowser --debug --wpe
Pass one of --gtk
, --jsc-only
, or --wpe
to indicate the port to use.
Congratulations! You’re up and running. Now you can begin coding in WebKit and contribute your fixes and new features to the project. For details on submitting your code to the project, read Contributing Code.