commit 00d5151e2f624826b885bfd7f794c17d79a680ff
author carlosgc@webkit.org <carlosgc@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Tue Jan 29 10:37:06 2019 +0000
committer carlosgc@webkit.org <carlosgc@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Tue Jan 29 10:37:06 2019 +0000
tree a8cb540abc41a43a69ffa2d6ee22114bd6afeba9
parent 1a0794d4490978a2f1f0913e7d8eeaa14d02218a

WebDriver: POST commands require a valid parameters object
https://bugs.webkit.org/show_bug.cgi?id=193906

Reviewed by Michael Catanzaro.

We are not failing when http body is empty.

Fixes tests: imported/w3c/webdriver/tests/set_window_rect/set.py::test_null_parameter_value
             imported/w3c/webdriver/tests/set_timeouts/set.py::test_null_parameter_value

* WebDriverService.cpp:
(WebDriver::WebDriverService::handleRequest):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@240648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebDriver/ChangeLog

diff --git a/Source/WebDriver/ChangeLog b/Source/WebDriver/ChangeLog
index 3921580..c9f8359 100644
--- a/Source/WebDriver/ChangeLog
+++ b/Source/WebDriver/ChangeLog
@@ -1,3 +1,18 @@
+2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        WebDriver: POST commands require a valid parameters object
+        https://bugs.webkit.org/show_bug.cgi?id=193906
+
+        Reviewed by Michael Catanzaro.
+
+        We are not failing when http body is empty.
+
+        Fixes tests: imported/w3c/webdriver/tests/set_window_rect/set.py::test_null_parameter_value
+                     imported/w3c/webdriver/tests/set_timeouts/set.py::test_null_parameter_value
+
+        * WebDriverService.cpp:
+        (WebDriver::WebDriverService::handleRequest):
+
 2019-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
 
         WebDriver: element click command should handle user prompts

Source/WebDriver/WebDriverService.cpp

diff --git a/Source/WebDriver/WebDriverService.cpp b/Source/WebDriver/WebDriverService.cpp
index e526882..05bc953 100644
--- a/Source/WebDriver/WebDriverService.cpp
+++ b/Source/WebDriver/WebDriverService.cpp
@@ -236,7 +236,7 @@
     }
 
     RefPtr<JSON::Object> parametersObject;
-    if (method.value() == HTTPMethod::Post && request.dataLength) {
+    if (method.value() == HTTPMethod::Post) {
         RefPtr<JSON::Value> messageValue;
         if (!JSON::Value::parseJSON(String::fromUTF8(request.data, request.dataLength), messageValue)) {
             sendResponse(WTFMove(replyHandler), CommandResult::fail(CommandResult::ErrorCode::InvalidArgument));